Fixed the run-android cli script to start the correct activity when using different applicationId for different variants #8950

kgritesh · 2016-07-21T18:43:35Z

This is a small fix in the runAndroid that instead of using the AndroidManifest file from the src at app/src/main/AndroidManifest.xml uses the manifest file that is generated during the build process to find out the correct package name and activity name. As a result, it solves the issue where runAndroid command fails to start the app after installing it.
Relevant Issue: #5546

ghost · 2016-07-21T18:45:20Z

By analyzing the blame information on this pull request, we identified @burgalon and @jimthedev to be potential reviewers.

mkonicek · 2016-07-31T14:20:21Z

From the issue:

I saw that for the command react-native run-android you guys are getting the package name of the application out of app/src/main/AndroidManifest.xml. This is ok if you change the application package in the gradle file AND in the AndroidManifest.xml.

What's the reason to change only one and not the other? Do you have an example when you'd do that?

This PR contains a lot of code, is there a way to solve this say with a few lines of code?

One thing not clear from the description of this PR: what's the new --activity argument for? When would someone use it?

tume · 2016-08-02T11:54:10Z

Sorry if i'm discussing in wrong place but I also had problems with applicationId as described and this pull request came closest when searching.

Our case is that we have same application built for different environments (dev/qa/prod) and we need to install those side-by-side so that is the reason for different applicationIds. If I have understood correctly the applicationId should be decoupled from the Androidmanifest.xml package_name exactly for this kind of purpose.

See more: http://tools.android.com/tech-docs/new-build-system/applicationid-vs-packagename

Not experienced enough on Android build systems to comment on actual implementation but would think that simpler option would be just to read straight the applicationId from build.gradle if there is no other problems with it.

ghost · 2016-08-20T05:50:51Z

@kgritesh updated the pull request - view changes

enterline · 2016-08-22T16:17:21Z

local-cli/runAndroid/runAndroid.js

+  const ret = splitVariant(gradleFilePath, variant);
+  const buildType = ret[0];
+  const flavor = ret[1];
+  const paths = ['android/app/build/intermediates/manifests/full'];


Since we are already in the android directory: https://github.com/facebook/react-native/pull/8950/files#diff-a003f89d34db18b4567fdb55080a003eR81

I believe these two file paths should be app/build.gradle and app/build/intermediates/manifests/full

@enterline yes you are right these two paths should be app/build.gradle and app/build/intermediates/manifests/full . I have updated my PR accordingly.

facebook-github-bot · 2016-08-23T03:05:56Z

@kgritesh updated the pull request - view changes

ghost · 2016-08-23T03:09:38Z

@kgritesh updated the pull request - view changes

ghost · 2016-09-20T12:40:26Z

@kgritesh updated the pull request - view changes

kgritesh · 2016-09-20T12:48:20Z

@mkonicek sorry for missing your comments earlier.
Android has concept of product flavors where for each flavour you can define a different package name inside build.gradle but the AndroidManifest.xml will still only have package name for your default flavor. For eg for our app, we have a product flavor called staging and we add a .staging to the package name , however android manifest file has the base package name, hence as the issue suggests its better to get the package name from the generated AndroidManifest file and not the default one

As per your other comment about that this pr contains lot of code, i don't think there is a simpler and cleaner way to solve this for all kind of corner cases

Finally the --activity options allows you to pass name of your launch activity incase its not called MainActivity. Most common use case is when you are adding react native to an existing app and the default launch activity is named something else

ghost · 2016-09-20T12:49:44Z

@kgritesh updated the pull request - view changes

StevePotter · 2016-10-17T21:35:19Z

💯 . This fixed my problem. Our build.gradle looks like:

    buildTypes {
        debug {
            applicationIdSuffix '.debug'
            versionNameSuffix '-DEBUG'
        }
        staging {
            applicationIdSuffix '.staging'
            versionNameSuffix '-STAGING'
        }
}

And so on. This PR fixes it perfectly. I worked like mad on #10178 and it just got merged. So should this one. The build scripts in react-native are weak and people like @kgritesh are improving it. Let's get this merged because right now I have to patch it. Thanks @kgritesh for your hard work!

kgritesh · 2016-10-18T04:23:29Z

thanks @StevePotter for your kind words. I am also waiting for this to get merged.

facebook-github-bot · 2016-10-18T04:23:58Z

@kgritesh updated the pull request - view changes

VictoriaQ · 2016-10-28T19:30:33Z

This fixed our issues, thanks!

Note that (at least in Linux), if you run it with react-native run-android --variant=myflavorDebug it will complain because it cannot find 'app/build/intermediates/manifests/full/myflavor/Debug/AndroidManifest.xml.

Running the task with the variant name in lowercase react-native run-android --variant=myflavordebug, works, however.

I think that buildType should be converted to lowercase in getManifestFile.

hramos · 2016-11-11T19:05:05Z

@mkonicek thoughts on this PR?

using different applicationId for different variants

chetstone · 2016-12-12T17:46:27Z

@mkonicek Any progress on merging this PR?

fkrauthan · 2017-01-12T03:15:41Z

Yeah what is going on? This merge request is super old. I already opened a bug about exactly this but it seems like no love for Android in react native :(

hramos · 2017-01-19T21:15:14Z

Thanks for the PR. I'd like to push for solving this issue with fewer lines of code as well.

kgritesh · 2017-01-20T04:14:13Z

Hey Hector, I will submit a new PR by end of this week making this better works?

…

On Fri, Jan 20, 2017 at 2:46 AM, Héctor Ramos ***@***.***> wrote: Thanks for the PR. I'd like to push for solving this issue with fewer lines of code as well. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8950 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADLpr1wgBLx-plIEyVrZYJ5AjDEgJNAZks5rT9KUgaJpZM4JSGM1> .

hramos · 2017-01-20T20:06:17Z

Does it need to be a new PR or can you land the commits on this one?

vongohren · 2017-02-01T16:12:27Z

Hows the work with this going?

vongohren · 2017-02-20T17:17:03Z

Is this getting anywhere? @kgritesh?
Or is there any other way of getting different environmentapps on the phone?
I would like to get 3 apps on my phone, dev, staging and prod. But currently this is not working with react beacuse it does not support applicationIdSuffix.

Can this be solved with any other solution? @hramos @mkonicek
I guess you guys have environmentapps on your projects?

hramos · 2017-02-22T19:31:23Z

@Snorlock @chuyik the original author has not responded in a while. If you're interested in fixing this, feel free to send a PR.

kgritesh · 2017-02-22T19:37:00Z

Sorry guys for not responding. I will surely try to refix this over next week and send another PR for latest version of react native.

…

On Thu, Feb 23, 2017 at 1:02 AM, Héctor Ramos ***@***.***> wrote: @Snorlock <https://github.com/Snorlock> @chuyik <https://github.com/chuyik> the original author has not responded in a while. If you're interested in fixing this, feel free to send a PR. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8950 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADLprxAVkZDzxQqWcgtYHlCA1P-2uoZnks5rfI1FgaJpZM4JSGM1> .

vongohren · 2017-03-08T21:40:08Z

It was closed because?

hramos · 2017-03-08T22:01:45Z

@Snorlock the author stated multiple times they will open a new PR that addresses the feedback provided above.

kgritesh · 2017-03-09T04:20:44Z

@Snorlock new PR submitted at #12820

facebook#8950

ghost added GH Review: review-needed CLA Signed labels Jul 21, 2016

kgritesh mentioned this pull request Jul 21, 2016

[Android] react-native run-android: Parsing of AndroidManifest.xml wrong #5546

Closed

kgritesh force-pushed the fix_run_android branch from fca786d to be2b67c Compare July 21, 2016 18:53

ghost added the CLA Signed label Jul 21, 2016

kgritesh force-pushed the fix_run_android branch from be2b67c to 26227b6 Compare August 20, 2016 05:49

ghost added the CLA Signed label Aug 20, 2016

alenia mentioned this pull request Aug 22, 2016

Added option to specify applicationId for Android builds #8867

Closed

enterline reviewed Aug 22, 2016
View reviewed changes

kgritesh force-pushed the fix_run_android branch from 26227b6 to 3a728fb Compare August 23, 2016 03:05

kgritesh force-pushed the fix_run_android branch from 3a728fb to 818a297 Compare August 23, 2016 03:08

ghost added the CLA Signed label Aug 23, 2016

ghost added CLA Signed labels Aug 30, 2016

ghost added the CLA Signed label Sep 7, 2016

kgritesh force-pushed the fix_run_android branch from 818a297 to cc67004 Compare September 20, 2016 12:38

kgritesh force-pushed the fix_run_android branch from cc67004 to 9068ddf Compare September 20, 2016 12:49

ghost added the CLA Signed label Sep 20, 2016

facebook-github-bot added the CLA Signed label Oct 17, 2016

facebook-github-bot added the CLA Signed label Oct 18, 2016

Fixed the run-android cli script to start the correct activity when

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

1350b35

using different applicationId for different variants

kgritesh force-pushed the fix_run_android branch from 53c4f9c to 1350b35 Compare November 27, 2016 06:16

chetstone mentioned this pull request Dec 12, 2016

In multi deployment builds, run-android launches the wrong version of the app microsoft/react-native-code-push#611

Closed

hramos added GH Review: needs-revision and removed GH Review: review-needed labels Jan 19, 2017

vongohren mentioned this pull request Feb 20, 2017

Android: Blank map when using applicationIdSuffix react-native-maps/react-native-maps#1021

Closed

vongohren mentioned this pull request Feb 27, 2017

run-android with custom package build variants launch wrong MainActivity #12480

Closed

kgritesh closed this Mar 8, 2017

kgritesh mentioned this pull request Mar 9, 2017

Fixed the run-android cli script to start the correct activity when using different applicationId for different variants #12820

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed the run-android cli script to start the correct activity when using different applicationId for different variants #8950

Fixed the run-android cli script to start the correct activity when using different applicationId for different variants #8950

kgritesh commented Jul 21, 2016

ghost commented Jul 21, 2016

mkonicek commented Jul 31, 2016 •

edited

Loading

tume commented Aug 2, 2016

ghost commented Aug 20, 2016

enterline Aug 22, 2016

kgritesh Aug 23, 2016

facebook-github-bot commented Aug 23, 2016

ghost commented Aug 23, 2016

ghost commented Sep 20, 2016

kgritesh commented Sep 20, 2016

ghost commented Sep 20, 2016

StevePotter commented Oct 17, 2016

kgritesh commented Oct 18, 2016

facebook-github-bot commented Oct 18, 2016

VictoriaQ commented Oct 28, 2016

hramos commented Nov 11, 2016

chetstone commented Dec 12, 2016

fkrauthan commented Jan 12, 2017

hramos commented Jan 19, 2017

kgritesh commented Jan 20, 2017 via email

hramos commented Jan 20, 2017

vongohren commented Feb 1, 2017

vongohren commented Feb 20, 2017

hramos commented Feb 22, 2017

kgritesh commented Feb 22, 2017 via email

vongohren commented Mar 8, 2017

hramos commented Mar 8, 2017

kgritesh commented Mar 9, 2017

Fixed the run-android cli script to start the correct activity when using different applicationId for different variants #8950

Fixed the run-android cli script to start the correct activity when using different applicationId for different variants #8950

Conversation

kgritesh commented Jul 21, 2016

ghost commented Jul 21, 2016

mkonicek commented Jul 31, 2016 • edited Loading

tume commented Aug 2, 2016

ghost commented Aug 20, 2016

enterline Aug 22, 2016

Choose a reason for hiding this comment

kgritesh Aug 23, 2016

Choose a reason for hiding this comment

facebook-github-bot commented Aug 23, 2016

ghost commented Aug 23, 2016

ghost commented Sep 20, 2016

kgritesh commented Sep 20, 2016

ghost commented Sep 20, 2016

StevePotter commented Oct 17, 2016

kgritesh commented Oct 18, 2016

facebook-github-bot commented Oct 18, 2016

VictoriaQ commented Oct 28, 2016

hramos commented Nov 11, 2016

chetstone commented Dec 12, 2016

fkrauthan commented Jan 12, 2017

hramos commented Jan 19, 2017

kgritesh commented Jan 20, 2017 via email

hramos commented Jan 20, 2017

vongohren commented Feb 1, 2017

vongohren commented Feb 20, 2017

hramos commented Feb 22, 2017

kgritesh commented Feb 22, 2017 via email

vongohren commented Mar 8, 2017

hramos commented Mar 8, 2017

kgritesh commented Mar 9, 2017

mkonicek commented Jul 31, 2016 •

edited

Loading