Expose getNode() on component created with createAnimatedComponent #9944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit eb3360b recently break some third libraries that was (weakly) relying on traversing animatedNode.refs.node to get the original node of the decorated component. Instead of now doing animatedNode._component (that might later break again), getNode() is a more 'public' solution for these third party. as you expose a way to create an animated component (createAnimatedComponent) you sometimes still want a way to get the reference. That way, third party component can continue providing some extra native methods to the animated version.
gre
referenced
this pull request
Sep 16, 2016
Summary: It was bothering me. Reviewed By: davidaurelio Differential Revision: D3690646 fbshipit-source-id: 50551f0bc4e879c36a262e923649745377ff0e2f
ghost
added
GH Review: review-needed
CLA Signed
|
cc @foghina |
ghost
added
the
CLA Signed
|
@facebook-github-bot shipit |
ghost
added
GH Review: accepted
Import Started
|
Thanks for importing. If you are an FB employee go to Phabricator to review internal test results. |
ghost
added
the
CLA Signed
|
hey @gre , just wondering, could it make sense to use the new |
|
@slorber definitely! |
|
great, just created a separate issue: #19650 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see also: eb3360b#commitcomment-19042340
commit eb3360b recently break some third libraries that was (weakly) relying on traversing
animatedNode.refs.nodeto get the original node of the decorated (animated) component (at least 2 libs: gl-react-native and react-native-material-kit).Instead of now doing
animatedNode._component(that might later break again), getNode() is a more 'public' solution for these third party.as you expose a way to create an animated component (
createAnimatedComponent) you sometimes still want a way to get the reference.That way, third party components can continue providing some extra native methods to the animated version.