Skip to content

Commit

Permalink
Revert 'Fabric-compatible implementation of feature' and have Fabric …
Browse files Browse the repository at this point in the history
…noop when setJSResponder is called for now
  • Loading branch information
JoshuaGross committed Mar 15, 2021
1 parent b9c4a01 commit 147c308
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,7 @@ const ReactFabricGlobalResponderHandler = {
const isFabric = !!fromOrTo.stateNode.canonical._internalInstanceHandle;

if (isFabric) {
if (from) {
nativeFabricUIManager.setIsJSResponder(from.stateNode.node, false);
}

if (to) {
nativeFabricUIManager.setIsJSResponder(to.stateNode.node, true);
}
// Noop for now until setJSResponder/clearJSResponder are supported in Fabric
} else {
if (to !== null) {
const tag = to.stateNode.canonical._nativeTag;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,6 @@ const RCTFabricUIManager = {
);
success(1, 1, 100, 100);
}),
setIsJSResponder: jest.fn(),
};

global.nativeFabricUIManager = RCTFabricUIManager;
1 change: 0 additions & 1 deletion scripts/flow/react-native-host-hooks.js
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,6 @@ declare var nativeFabricUIManager: {
locationY: number,
callback: (Fiber) => void,
) => void,
setIsJSResponder: (node: Node, isJsResponder: boolean) => void,
...
};

Expand Down

0 comments on commit 147c308

Please sign in to comment.