Skip to content

Commit

Permalink
remove flow check in electron app.js (#26184)
Browse files Browse the repository at this point in the history
When we were upgrading flow in
6ddcbd4
we added `$FlowFixMe` for some parameters in this file. However, this
file is not compiled at all, and the `:` syntax breaks the code.

This PR removes the flow check in this file
  • Loading branch information
mondaychen committed Feb 17, 2023
1 parent 4fcc918 commit 1a49e2d
Showing 1 changed file with 4 additions and 12 deletions.
16 changes: 4 additions & 12 deletions packages/react-devtools/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow
*/

const {app, BrowserWindow} = require('electron'); // Module to create native browser window.
Expand Down Expand Up @@ -40,17 +38,12 @@ app.on('ready', function () {
}

// https://stackoverflow.com/questions/32402327/
// $FlowFixMe[incompatible-use] found when upgrading Flow
mainWindow.webContents.on(
'new-window',
function (event: $FlowFixMe, url: $FlowFixMe) {
event.preventDefault();
require('electron').shell.openExternal(url);
},
);
mainWindow.webContents.on('new-window', function (event, url) {
event.preventDefault();
require('electron').shell.openExternal(url);
});

// and load the index.html of the app.
// $FlowFixMe[incompatible-use] found when upgrading Flow
mainWindow.loadURL('file://' + __dirname + '/app.html'); // eslint-disable-line no-path-concat
// $FlowFixMe[incompatible-use] found when upgrading Flow
mainWindow.webContents.executeJavaScript(
Expand All @@ -61,7 +54,6 @@ app.on('ready', function () {
);

// Emitted when the window is closed.
// $FlowFixMe[incompatible-use] found when upgrading Flow
mainWindow.on('closed', function () {
mainWindow = null;
});
Expand Down

0 comments on commit 1a49e2d

Please sign in to comment.