compiler: Add support for ref effects

Fixes false positives where we currently disallow mutations of refs from callbacks passed to JSX, if the ref is also passed to jsx. We consider these to be mutations of "frozen" values, but refs are explicitly allowed to have interior mutability. The fix is to always allow (at leat within InferReferenceEffects) for refs to be mutated. This means we completely rely on ValidateNoRefAccessInRender to validate ref access and stop reporting false positives. ghstack-source-id: 1a30609f5f7831086077d10dac46ab70687f47e0 Pull Request resolved: #29733 DiffTrain build for commit 827cbea.
facebook · Jun 7, 2024 · 1ecce6c · 1ecce6c
1 parent 7273329
commit 1ecce6c
Show file tree

Hide file tree

Showing 14 changed files with 36 additions and 36 deletions.
diff --git a/compiled-rn/VERSION_NATIVE_FB b/compiled-rn/VERSION_NATIVE_FB
@@ -1 +1 @@
-19.0.0-native-fb-c4b433f8cb-20240606
+19.0.0-native-fb-827cbea417-20240606
diff --git a/...source/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-dev.js b/...source/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-dev.js
@@ -7,7 +7,7 @@
  * @noflow
  * @nolint
  * @preventMunge
- * @generated SignedSource<<032d7dd89691171b14786d598e0bbc99>>
+ * @generated SignedSource<<38ebc8eb26209e95bf95aa9632879a86>>
  */
 
 'use strict';
@@ -23580,7 +23580,7 @@ identifierPrefix, onUncaughtError, onCaughtError, onRecoverableError, transition
  return root;
 }
 
-var ReactVersion = '19.0.0-native-fb-c4b433f8cb-20240606';
+var ReactVersion = '19.0.0-native-fb-827cbea417-20240606';
 
 /*
  * The `'' + value` pattern (used in perf-sensitive code) throws for Symbol

diff --git a/...ource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-prod.js b/...ource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-prod.js
@@ -7,7 +7,7 @@
  * @noflow
  * @nolint
  * @preventMunge
- * @generated SignedSource<<12c0c993269444b52e9abfb797084cb4>>
+ * @generated SignedSource<<c6a8246581c45b63b7094d3fe4e78c73>>
  */
 
 "use strict";
@@ -9336,7 +9336,7 @@ var devToolsConfig$jscomp$inline_1048 = {
  throw Error("TestRenderer does not support findFiberByHostInstance()");
  },
  bundleType: 0,
- version: "19.0.0-native-fb-c4b433f8cb-20240606",
+ version: "19.0.0-native-fb-827cbea417-20240606",
  rendererPackageName: "react-test-renderer"
 };
 var internals$jscomp$inline_1235 = {
@@ -9367,7 +9367,7 @@ var internals$jscomp$inline_1235 = {
  scheduleRoot: null,
  setRefreshHandler: null,
  getCurrentFiber: null,
- reconcilerVersion: "19.0.0-native-fb-c4b433f8cb-20240606"
+ reconcilerVersion: "19.0.0-native-fb-827cbea417-20240606"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
  var hook$jscomp$inline_1236 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

diff --git a/.../xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-profiling.js b/.../xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-profiling.js
@@ -7,7 +7,7 @@
  * @noflow
  * @nolint
  * @preventMunge
- * @generated SignedSource<<6f9ea2f557350b7fa86523f1eec45bde>>
+ * @generated SignedSource<<be4c77c41dfc7c8234fe0aff99974be6>>
  */
 
 "use strict";
@@ -9958,7 +9958,7 @@ var devToolsConfig$jscomp$inline_1131 = {
  throw Error("TestRenderer does not support findFiberByHostInstance()");
  },
  bundleType: 0,
- version: "19.0.0-native-fb-c4b433f8cb-20240606",
+ version: "19.0.0-native-fb-827cbea417-20240606",
  rendererPackageName: "react-test-renderer"
 };
 (function (internals) {
@@ -10002,7 +10002,7 @@ var devToolsConfig$jscomp$inline_1131 = {
  scheduleRoot: null,
  setRefreshHandler: null,
  getCurrentFiber: null,
- reconcilerVersion: "19.0.0-native-fb-c4b433f8cb-20240606"
+ reconcilerVersion: "19.0.0-native-fb-827cbea417-20240606"
 });
 exports._Scheduler = Scheduler;
 exports.act = act;

diff --git a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-dev.js b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-dev.js
@@ -7,7 +7,7 @@
  * @noflow
  * @nolint
  * @preventMunge
- * @generated SignedSource<<68dbc7308bfbb7d05227a50e3eeb3e57>>
+ * @generated SignedSource<<f0572e0535e05e5b4c34c75104049104>>
  */
 
 'use strict';
@@ -24,7 +24,7 @@ if (
 }
 var dynamicFlagsUntyped = require('ReactNativeInternalFeatureFlags');
 
-var ReactVersion = '19.0.0-native-fb-c4b433f8cb-20240606';
+var ReactVersion = '19.0.0-native-fb-827cbea417-20240606';
 
 // Re-export dynamic flags from the internal module.
 var dynamicFlags = dynamicFlagsUntyped; // We destructure each value before re-exporting to avoid a dynamic look-up on

diff --git a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-prod.js b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-prod.js
@@ -7,7 +7,7 @@
  * @noflow
  * @nolint
  * @preventMunge
- * @generated SignedSource<<f1665633ce08787576402deeb5531665>>
+ * @generated SignedSource<<f492bd5a8de1e2e9b1c7e2ed6ec6f3e8>>
  */
 
 "use strict";
@@ -604,4 +604,4 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
  return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.0.0-native-fb-c4b433f8cb-20240606";
+exports.version = "19.0.0-native-fb-827cbea417-20240606";
diff --git a/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-profiling.js b/compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-profiling.js
@@ -7,7 +7,7 @@
  * @noflow
  * @nolint
  * @preventMunge
- * @generated SignedSource<<36642fd62ebc527de38ec42de81f2eee>>
+ * @generated SignedSource<<87749d31a3257a06a60d43aabf38e851>>
  */
 
 "use strict";
@@ -608,7 +608,7 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
  return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.0.0-native-fb-c4b433f8cb-20240606";
+exports.version = "19.0.0-native-fb-827cbea417-20240606";
 "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
  "function" ===
  typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

diff --git a/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION b/compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION
@@ -1 +1 @@
-c4b433f8cb31d6f73d4a800fcf11ed55c8689daf
+827cbea417a4058ce544184adff2ee2014625309
diff --git a/...rce/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js b/...rce/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js
@@ -7,7 +7,7 @@
  * @noflow
  * @nolint
  * @preventMunge
- * @generated SignedSource<<f6a834b91eb2d202c2962a8e94dd5f1d>>
+ * @generated SignedSource<<3225b7381e9e7d376d58f185e585d308>>
  */
 
 'use strict';
@@ -26316,7 +26316,7 @@ identifierPrefix, onUncaughtError, onCaughtError, onRecoverableError, transition
  return root;
 }
 
-var ReactVersion = '19.0.0-native-fb-c4b433f8cb-20240606';
+var ReactVersion = '19.0.0-native-fb-827cbea417-20240606';
 
 /*
  * The `'' + value` pattern (used in perf-sensitive code) throws for Symbol

diff --git a/...ce/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js b/...ce/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js
@@ -7,7 +7,7 @@
  * @noflow
  * @nolint
  * @preventMunge
- * @generated SignedSource<<92715300fd590ddea9ce1dd72306e4db>>
+ * @generated SignedSource<<66f48c9a043ffad46848774dba6bedf4>>
  */
 
 "use strict";
@@ -10591,7 +10591,7 @@ var roots = new Map(),
  devToolsConfig$jscomp$inline_1125 = {
  findFiberByHostInstance: getInstanceFromNode,
  bundleType: 0,
- version: "19.0.0-native-fb-c4b433f8cb-20240606",
+ version: "19.0.0-native-fb-827cbea417-20240606",
  rendererPackageName: "react-native-renderer",
  rendererConfig: {
  getInspectorDataForInstance: getInspectorDataForInstance,
@@ -10634,7 +10634,7 @@ var internals$jscomp$inline_1351 = {
  scheduleRoot: null,
  setRefreshHandler: null,
  getCurrentFiber: null,
- reconcilerVersion: "19.0.0-native-fb-c4b433f8cb-20240606"
+ reconcilerVersion: "19.0.0-native-fb-827cbea417-20240606"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
  var hook$jscomp$inline_1352 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

diff --git a/...lat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-profiling.fb.js b/...lat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-profiling.fb.js
@@ -7,7 +7,7 @@
  * @noflow
  * @nolint
  * @preventMunge
- * @generated SignedSource<<22f316c398242893f81035c7372215b9>>
+ * @generated SignedSource<<ebd5f0fcbb6e2a93d159eea2116be917>>
  */
 
 "use strict";
@@ -11297,7 +11297,7 @@ var roots = new Map(),
  devToolsConfig$jscomp$inline_1206 = {
  findFiberByHostInstance: getInstanceFromNode,
  bundleType: 0,
- version: "19.0.0-native-fb-c4b433f8cb-20240606",
+ version: "19.0.0-native-fb-827cbea417-20240606",
  rendererPackageName: "react-native-renderer",
  rendererConfig: {
  getInspectorDataForInstance: getInspectorDataForInstance,
@@ -11353,7 +11353,7 @@ var roots = new Map(),
  scheduleRoot: null,
  setRefreshHandler: null,
  getCurrentFiber: null,
- reconcilerVersion: "19.0.0-native-fb-c4b433f8cb-20240606"
+ reconcilerVersion: "19.0.0-native-fb-827cbea417-20240606"
 });
 exports.createPortal = function (children, containerTag) {
  return createPortal$1(

diff --git a/...t/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-dev.fb.js b/...t/js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-dev.fb.js
@@ -7,7 +7,7 @@
  * @noflow
  * @nolint
  * @preventMunge
- * @generated SignedSource<<b53c47b09559ce134089279362dfa676>>
+ * @generated SignedSource<<7ccdee1e437ca7050ae8d3bf7ba0d2de>>
  */
 
 'use strict';
@@ -26671,7 +26671,7 @@ identifierPrefix, onUncaughtError, onCaughtError, onRecoverableError, transition
  return root;
 }
 
-var ReactVersion = '19.0.0-native-fb-c4b433f8cb-20240606';
+var ReactVersion = '19.0.0-native-fb-827cbea417-20240606';
 
 /*
  * The `'' + value` pattern (used in perf-sensitive code) throws for Symbol

diff --git a/.../js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-prod.fb.js b/.../js/react-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-prod.fb.js
@@ -7,7 +7,7 @@
  * @noflow
  * @nolint
  * @preventMunge
- * @generated SignedSource<<0cd1a72d3ab3902ed0d225a881c422bc>>
+ * @generated SignedSource<<610df2ef1754efd4939af09e867d7b1a>>
  */
 
 "use strict";
@@ -10734,11 +10734,11 @@ function traverseOwnerTreeUp(hierarchy, instance) {
  traverseOwnerTreeUp(hierarchy, instance);
 }
 var isomorphicReactPackageVersion = React.version;
-if ("19.0.0-native-fb-c4b433f8cb-20240606" !== isomorphicReactPackageVersion)
+if ("19.0.0-native-fb-827cbea417-20240606" !== isomorphicReactPackageVersion)
  throw Error(
  'Incompatible React versions: The "react" and "react-native-renderer" packages must have the exact same version. Instead got:\n - react: ' +
  (isomorphicReactPackageVersion +
- "\n - react-native-renderer: 19.0.0-native-fb-c4b433f8cb-20240606\nLearn more: https://react.dev/warnings/version-mismatch")
+ "\n - react-native-renderer: 19.0.0-native-fb-827cbea417-20240606\nLearn more: https://react.dev/warnings/version-mismatch")
  );
 if (
  "function" !==
@@ -10788,7 +10788,7 @@ var roots = new Map(),
  devToolsConfig$jscomp$inline_1193 = {
  findFiberByHostInstance: getInstanceFromTag,
  bundleType: 0,
- version: "19.0.0-native-fb-c4b433f8cb-20240606",
+ version: "19.0.0-native-fb-827cbea417-20240606",
  rendererPackageName: "react-native-renderer",
  rendererConfig: {
  getInspectorDataForInstance: getInspectorDataForInstance,
@@ -10831,7 +10831,7 @@ var internals$jscomp$inline_1440 = {
  scheduleRoot: null,
  setRefreshHandler: null,
  getCurrentFiber: null,
- reconcilerVersion: "19.0.0-native-fb-c4b433f8cb-20240606"
+ reconcilerVersion: "19.0.0-native-fb-827cbea417-20240606"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
  var hook$jscomp$inline_1441 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

diff --git a/...eact-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-profiling.fb.js b/...eact-native-github/Libraries/Renderer/implementations/ReactNativeRenderer-profiling.fb.js
@@ -7,7 +7,7 @@
  * @noflow
  * @nolint
  * @preventMunge
- * @generated SignedSource<<2bbf05d02bdf0cbcebdab4f1104c2563>>
+ * @generated SignedSource<<8b0a829eb812952da68255a848dea817>>
  */
 
 "use strict";
@@ -11441,11 +11441,11 @@ function traverseOwnerTreeUp(hierarchy, instance) {
  traverseOwnerTreeUp(hierarchy, instance);
 }
 var isomorphicReactPackageVersion = React.version;
-if ("19.0.0-native-fb-c4b433f8cb-20240606" !== isomorphicReactPackageVersion)
+if ("19.0.0-native-fb-827cbea417-20240606" !== isomorphicReactPackageVersion)
  throw Error(
  'Incompatible React versions: The "react" and "react-native-renderer" packages must have the exact same version. Instead got:\n - react: ' +
  (isomorphicReactPackageVersion +
- "\n - react-native-renderer: 19.0.0-native-fb-c4b433f8cb-20240606\nLearn more: https://react.dev/warnings/version-mismatch")
+ "\n - react-native-renderer: 19.0.0-native-fb-827cbea417-20240606\nLearn more: https://react.dev/warnings/version-mismatch")
  );
 if (
  "function" !==
@@ -11495,7 +11495,7 @@ var roots = new Map(),
  devToolsConfig$jscomp$inline_1274 = {
  findFiberByHostInstance: getInstanceFromTag,
  bundleType: 0,
- version: "19.0.0-native-fb-c4b433f8cb-20240606",
+ version: "19.0.0-native-fb-827cbea417-20240606",
  rendererPackageName: "react-native-renderer",
  rendererConfig: {
  getInspectorDataForInstance: getInspectorDataForInstance,
@@ -11551,7 +11551,7 @@ var roots = new Map(),
  scheduleRoot: null,
  setRefreshHandler: null,
  getCurrentFiber: null,
- reconcilerVersion: "19.0.0-native-fb-c4b433f8cb-20240606"
+ reconcilerVersion: "19.0.0-native-fb-827cbea417-20240606"
 });
 exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = {
  computeComponentStackForErrorReporting: function (reactTag) {