Skip to content

Commit

Permalink
Rephrase deprecation messages for clarity
Browse files Browse the repository at this point in the history
**what is the change?:**
We rephrased the deprecation messages to clarify that
 - these APIs are currently deprecated
 - they will be removed in React v16.0

The previous wording implied that they would be deprecated in v16.0.

**why make this change?:**
To make the messages easier to understand.

**test plan:**
Visual inspection
  • Loading branch information
flarnie committed May 25, 2017
1 parent 6f9ae55 commit 404772e
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions src/isomorphic/React.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,10 @@ if (__DEV__) {
createMixin = function(mixin) {
lowPriorityWarning(
warnedForCreateMixin,
'In React 16.0, React.createMixin is deprecated and should not be used. ' +
'You can use this mixin directly instead.' +
' See (https://fb.me/createmixin-was-never-implemented) for more info.',
'React.createMixin is deprecated and should not be used. ' +
'In React v16.0, it will be removed. ' +
'You can use this mixin directly instead. ' +
'See https://fb.me/createmixin-was-never-implemented for more info.',
);
warnedForCreateMixin = true;
return mixin;
Expand Down Expand Up @@ -110,8 +111,9 @@ if (__DEV__) {
get() {
lowPriorityWarning(
didWarnPropTypesDeprecated,
'In React v16.0+, accessing PropTypes via the main React package is deprecated. Use ' +
'the prop-types package from npm instead.' +
'Accessing PropTypes via the main React package is deprecated,' +
' and will be removed in React v16.0.' +
' Use the prop-types package from npm instead.' +
' Version 15.5.10 provides a drop-in replacement.' +
' For info on usage, compatibility, migration and more, see ' +
'https://fb.me/prop-types-docs',
Expand Down

0 comments on commit 404772e

Please sign in to comment.