Skip to content

Commit

Permalink
Revert "Cleanup enableSyncDefaultUpdate flag (#26236)" (#26528)
Browse files Browse the repository at this point in the history
This reverts commit b2ae9dd.

While the feature flag is fully rolled out, these tests are also testing
behavior set with an unstable flag on root, which for now we want to
preserve.

Not sure if there's a better way then adding a dynamic feature flag to
the www build?

DiffTrain build for [da94e8b](da94e8b)
  • Loading branch information
kassens committed Apr 4, 2023
1 parent 8fb86b0 commit 5b5baac
Show file tree
Hide file tree
Showing 17 changed files with 106 additions and 60 deletions.
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
4a1cc2ddd035f5c269e82ab6f7686e2e60d3b3ea
da94e8b24a3f31a3e805f9bf6bba73055aad9d41
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ if (
}
"use strict";

var ReactVersion = "18.3.0-www-modern-be9a0998";
var ReactVersion = "18.3.0-www-modern-c754d90a";

// ATTENTION
// When adding new symbols to this file,
Expand Down
7 changes: 5 additions & 2 deletions compiled/facebook-www/ReactART-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
return self;
}

var ReactVersion = "18.3.0-www-classic-ec4b0889";
var ReactVersion = "18.3.0-www-classic-828157c0";

var LegacyRoot = 0;
var ConcurrentRoot = 1;
Expand Down Expand Up @@ -173,6 +173,7 @@ var revertRemovalOfSiblingPrerendering =
enableUseRefAccessWarning = dynamicFeatureFlags.enableUseRefAccessWarning,
enableLazyContextPropagation =
dynamicFeatureFlags.enableLazyContextPropagation,
enableSyncDefaultUpdates = dynamicFeatureFlags.enableSyncDefaultUpdates,
enableUnifiedSyncLane = dynamicFeatureFlags.enableUnifiedSyncLane,
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
enableDeferRootSchedulingToMicrotask =
Expand Down Expand Up @@ -27698,7 +27699,9 @@ function createHostRootFiber(
}

if (
// Only for internal experiments.
// We only use this flag for our repo tests to check both behaviors.
// TODO: Flip this flag and rename it something like "forceConcurrentByDefaultForTesting"
!enableSyncDefaultUpdates || // Only for internal experiments.
concurrentUpdatesByDefaultOverride
) {
mode |= ConcurrentUpdatesByDefaultMode;
Expand Down
7 changes: 5 additions & 2 deletions compiled/facebook-www/ReactART-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
return self;
}

var ReactVersion = "18.3.0-www-modern-ae3f1831";
var ReactVersion = "18.3.0-www-modern-0165cfa3";

var LegacyRoot = 0;
var ConcurrentRoot = 1;
Expand Down Expand Up @@ -173,6 +173,7 @@ var revertRemovalOfSiblingPrerendering =
enableUseRefAccessWarning = dynamicFeatureFlags.enableUseRefAccessWarning,
enableLazyContextPropagation =
dynamicFeatureFlags.enableLazyContextPropagation,
enableSyncDefaultUpdates = dynamicFeatureFlags.enableSyncDefaultUpdates,
enableUnifiedSyncLane = dynamicFeatureFlags.enableUnifiedSyncLane,
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
enableDeferRootSchedulingToMicrotask =
Expand Down Expand Up @@ -27358,7 +27359,9 @@ function createHostRootFiber(
}

if (
// Only for internal experiments.
// We only use this flag for our repo tests to check both behaviors.
// TODO: Flip this flag and rename it something like "forceConcurrentByDefaultForTesting"
!enableSyncDefaultUpdates || // Only for internal experiments.
concurrentUpdatesByDefaultOverride
) {
mode |= ConcurrentUpdatesByDefaultMode;
Expand Down
4 changes: 2 additions & 2 deletions compiled/facebook-www/ReactART-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -9732,7 +9732,7 @@ var slice = Array.prototype.slice,
return null;
},
bundleType: 0,
version: "18.3.0-www-modern-d98f8218",
version: "18.3.0-www-modern-bf67bce4",
rendererPackageName: "react-art"
};
var internals$jscomp$inline_1324 = {
Expand Down Expand Up @@ -9763,7 +9763,7 @@ var internals$jscomp$inline_1324 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-www-modern-d98f8218"
reconcilerVersion: "18.3.0-www-modern-bf67bce4"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1325 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
7 changes: 5 additions & 2 deletions compiled/facebook-www/ReactDOM-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ var disableInputAttributeSyncing =
enableUseRefAccessWarning = dynamicFeatureFlags.enableUseRefAccessWarning,
enableLazyContextPropagation =
dynamicFeatureFlags.enableLazyContextPropagation,
enableSyncDefaultUpdates = dynamicFeatureFlags.enableSyncDefaultUpdates,
enableUnifiedSyncLane = dynamicFeatureFlags.enableUnifiedSyncLane,
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
enableCustomElementPropertySupport =
Expand Down Expand Up @@ -33338,7 +33339,9 @@ function createHostRootFiber(
}

if (
// Only for internal experiments.
// We only use this flag for our repo tests to check both behaviors.
// TODO: Flip this flag and rename it something like "forceConcurrentByDefaultForTesting"
!enableSyncDefaultUpdates || // Only for internal experiments.
concurrentUpdatesByDefaultOverride
) {
mode |= ConcurrentUpdatesByDefaultMode;
Expand Down Expand Up @@ -33893,7 +33896,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-classic-3e8e5cab";
var ReactVersion = "18.3.0-www-classic-3f441887";

function createPortal$1(
children,
Expand Down
7 changes: 5 additions & 2 deletions compiled/facebook-www/ReactDOM-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,7 @@ var disableInputAttributeSyncing =
enableUseRefAccessWarning = dynamicFeatureFlags.enableUseRefAccessWarning,
enableLazyContextPropagation =
dynamicFeatureFlags.enableLazyContextPropagation,
enableSyncDefaultUpdates = dynamicFeatureFlags.enableSyncDefaultUpdates,
enableUnifiedSyncLane = dynamicFeatureFlags.enableUnifiedSyncLane,
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
enableCustomElementPropertySupport =
Expand Down Expand Up @@ -33177,7 +33178,9 @@ function createHostRootFiber(
}

if (
// Only for internal experiments.
// We only use this flag for our repo tests to check both behaviors.
// TODO: Flip this flag and rename it something like "forceConcurrentByDefaultForTesting"
!enableSyncDefaultUpdates || // Only for internal experiments.
concurrentUpdatesByDefaultOverride
) {
mode |= ConcurrentUpdatesByDefaultMode;
Expand Down Expand Up @@ -33732,7 +33735,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-modern-d98f8218";
var ReactVersion = "18.3.0-www-modern-bf67bce4";

function createPortal$1(
children,
Expand Down
18 changes: 11 additions & 7 deletions compiled/facebook-www/ReactDOM-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ var ReactSharedInternals =
enableUseRefAccessWarning = dynamicFeatureFlags.enableUseRefAccessWarning,
enableLazyContextPropagation =
dynamicFeatureFlags.enableLazyContextPropagation,
enableSyncDefaultUpdates = dynamicFeatureFlags.enableSyncDefaultUpdates,
enableUnifiedSyncLane = dynamicFeatureFlags.enableUnifiedSyncLane,
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
enableCustomElementPropertySupport =
Expand Down Expand Up @@ -11835,11 +11836,14 @@ function createFiberRoot(
containerInfo.hydrationCallbacks = hydrationCallbacks;
enableTransitionTracing &&
(containerInfo.transitionCallbacks = transitionCallbacks);
1 === tag
? ((tag = 1),
if (1 === tag) {
if (
((tag = 1),
!0 === isStrictMode && (tag |= 24),
concurrentUpdatesByDefaultOverride && (tag |= 32))
: (tag = 0);
!enableSyncDefaultUpdates || concurrentUpdatesByDefaultOverride)
)
tag |= 32;
} else tag = 0;
isStrictMode = createFiber(3, null, null, tag);
containerInfo.current = isStrictMode;
isStrictMode.stateNode = containerInfo;
Expand Down Expand Up @@ -15966,7 +15970,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1812 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-classic-fec0aa60",
version: "18.3.0-www-classic-067cf99f",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2208 = {
Expand Down Expand Up @@ -15996,7 +16000,7 @@ var internals$jscomp$inline_2208 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-www-classic-fec0aa60"
reconcilerVersion: "18.3.0-www-classic-067cf99f"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2209 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -16236,4 +16240,4 @@ exports.unstable_renderSubtreeIntoContainer = function (
);
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-www-classic-fec0aa60";
exports.version = "18.3.0-www-classic-067cf99f";
18 changes: 11 additions & 7 deletions compiled/facebook-www/ReactDOM-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ var dynamicFeatureFlags = require("ReactFeatureFlags"),
enableUseRefAccessWarning = dynamicFeatureFlags.enableUseRefAccessWarning,
enableLazyContextPropagation =
dynamicFeatureFlags.enableLazyContextPropagation,
enableSyncDefaultUpdates = dynamicFeatureFlags.enableSyncDefaultUpdates,
enableUnifiedSyncLane = dynamicFeatureFlags.enableUnifiedSyncLane,
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
enableCustomElementPropertySupport =
Expand Down Expand Up @@ -11635,11 +11636,14 @@ function createFiberRoot(
containerInfo.hydrationCallbacks = hydrationCallbacks;
enableTransitionTracing &&
(containerInfo.transitionCallbacks = transitionCallbacks);
1 === tag
? ((tag = 1),
if (1 === tag) {
if (
((tag = 1),
!0 === isStrictMode && (tag |= 24),
concurrentUpdatesByDefaultOverride && (tag |= 32))
: (tag = 0);
!enableSyncDefaultUpdates || concurrentUpdatesByDefaultOverride)
)
tag |= 32;
} else tag = 0;
isStrictMode = createFiber(3, null, null, tag);
containerInfo.current = isStrictMode;
isStrictMode.stateNode = containerInfo;
Expand Down Expand Up @@ -15493,7 +15497,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1770 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-modern-e2caad0b",
version: "18.3.0-www-modern-1e3e94dc",
rendererPackageName: "react-dom"
};
var internals$jscomp$inline_2171 = {
Expand Down Expand Up @@ -15524,7 +15528,7 @@ var internals$jscomp$inline_2171 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-www-modern-e2caad0b"
reconcilerVersion: "18.3.0-www-modern-1e3e94dc"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2172 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -15693,4 +15697,4 @@ exports.unstable_createEventHandle = function (type, options) {
return eventHandle;
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-www-modern-e2caad0b";
exports.version = "18.3.0-www-modern-1e3e94dc";
18 changes: 11 additions & 7 deletions compiled/facebook-www/ReactDOM-profiling.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ var ReactSharedInternals =
enableUseRefAccessWarning = dynamicFeatureFlags.enableUseRefAccessWarning,
enableLazyContextPropagation =
dynamicFeatureFlags.enableLazyContextPropagation,
enableSyncDefaultUpdates = dynamicFeatureFlags.enableSyncDefaultUpdates,
enableUnifiedSyncLane = dynamicFeatureFlags.enableUnifiedSyncLane,
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
enableCustomElementPropertySupport =
Expand Down Expand Up @@ -12603,11 +12604,14 @@ function createFiberRoot(
containerInfo.hydrationCallbacks = hydrationCallbacks;
enableTransitionTracing &&
(containerInfo.transitionCallbacks = transitionCallbacks);
1 === tag
? ((tag = 1),
if (1 === tag) {
if (
((tag = 1),
!0 === isStrictMode && (tag |= 24),
concurrentUpdatesByDefaultOverride && (tag |= 32))
: (tag = 0);
!enableSyncDefaultUpdates || concurrentUpdatesByDefaultOverride)
)
tag |= 32;
} else tag = 0;
isDevToolsPresent && (tag |= 2);
isStrictMode = createFiber(3, null, null, tag);
containerInfo.current = isStrictMode;
Expand Down Expand Up @@ -16740,7 +16744,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1891 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-classic-a30ed13a",
version: "18.3.0-www-classic-03ed5162",
rendererPackageName: "react-dom"
};
(function (internals) {
Expand Down Expand Up @@ -16784,7 +16788,7 @@ var devToolsConfig$jscomp$inline_1891 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-www-classic-a30ed13a"
reconcilerVersion: "18.3.0-www-classic-03ed5162"
});
assign(Internals, {
ReactBrowserEventEmitter: {
Expand Down Expand Up @@ -17011,7 +17015,7 @@ exports.unstable_renderSubtreeIntoContainer = function (
);
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-www-classic-a30ed13a";
exports.version = "18.3.0-www-classic-03ed5162";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
18 changes: 11 additions & 7 deletions compiled/facebook-www/ReactDOM-profiling.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ var dynamicFeatureFlags = require("ReactFeatureFlags"),
enableUseRefAccessWarning = dynamicFeatureFlags.enableUseRefAccessWarning,
enableLazyContextPropagation =
dynamicFeatureFlags.enableLazyContextPropagation,
enableSyncDefaultUpdates = dynamicFeatureFlags.enableSyncDefaultUpdates,
enableUnifiedSyncLane = dynamicFeatureFlags.enableUnifiedSyncLane,
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
enableCustomElementPropertySupport =
Expand Down Expand Up @@ -12397,11 +12398,14 @@ function createFiberRoot(
containerInfo.hydrationCallbacks = hydrationCallbacks;
enableTransitionTracing &&
(containerInfo.transitionCallbacks = transitionCallbacks);
1 === tag
? ((tag = 1),
if (1 === tag) {
if (
((tag = 1),
!0 === isStrictMode && (tag |= 24),
concurrentUpdatesByDefaultOverride && (tag |= 32))
: (tag = 0);
!enableSyncDefaultUpdates || concurrentUpdatesByDefaultOverride)
)
tag |= 32;
} else tag = 0;
isDevToolsPresent && (tag |= 2);
isStrictMode = createFiber(3, null, null, tag);
containerInfo.current = isStrictMode;
Expand Down Expand Up @@ -16261,7 +16265,7 @@ Internals.Events = [
var devToolsConfig$jscomp$inline_1849 = {
findFiberByHostInstance: getClosestInstanceFromNode,
bundleType: 0,
version: "18.3.0-www-modern-f4c1fdba",
version: "18.3.0-www-modern-2e9b50ad",
rendererPackageName: "react-dom"
};
(function (internals) {
Expand Down Expand Up @@ -16306,7 +16310,7 @@ var devToolsConfig$jscomp$inline_1849 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-www-modern-f4c1fdba"
reconcilerVersion: "18.3.0-www-modern-2e9b50ad"
});
exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = Internals;
exports.createPortal = function (children, container) {
Expand Down Expand Up @@ -16462,7 +16466,7 @@ exports.unstable_createEventHandle = function (type, options) {
return eventHandle;
};
exports.unstable_runWithPriority = runWithPriority;
exports.version = "18.3.0-www-modern-f4c1fdba";
exports.version = "18.3.0-www-modern-2e9b50ad";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
7 changes: 5 additions & 2 deletions compiled/facebook-www/ReactDOMTesting-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ var disableInputAttributeSyncing =
enableUseRefAccessWarning = dynamicFeatureFlags.enableUseRefAccessWarning,
enableLazyContextPropagation =
dynamicFeatureFlags.enableLazyContextPropagation,
enableSyncDefaultUpdates = dynamicFeatureFlags.enableSyncDefaultUpdates,
enableUnifiedSyncLane = dynamicFeatureFlags.enableUnifiedSyncLane,
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing,
enableCustomElementPropertySupport =
Expand Down Expand Up @@ -35392,7 +35393,9 @@ function createHostRootFiber(
}

if (
// Only for internal experiments.
// We only use this flag for our repo tests to check both behaviors.
// TODO: Flip this flag and rename it something like "forceConcurrentByDefaultForTesting"
!enableSyncDefaultUpdates || // Only for internal experiments.
concurrentUpdatesByDefaultOverride
) {
mode |= ConcurrentUpdatesByDefaultMode;
Expand Down Expand Up @@ -35947,7 +35950,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-www-classic-9a1ec795";
var ReactVersion = "18.3.0-www-classic-a8de269b";

function createPortal$1(
children,
Expand Down
Loading

0 comments on commit 5b5baac

Please sign in to comment.