patchConsoleForInitialRenderInStrictMode-> `patchConsoleForInitialC…

…ommitInStrictMode`
facebook · May 20, 2024 · 6a4f521 · 6a4f521
1 parent ecfb9bc
commit 6a4f521
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/packages/react-devtools-shared/src/backend/console.js b/packages/react-devtools-shared/src/backend/console.js
@@ -294,7 +294,7 @@ export function unpatch(): void {
 
 let unpatchForStrictModeFn: null | (() => void) = null;
 
-// NOTE: KEEP IN SYNC with src/hook.js:patchConsoleForInitialRenderInStrictMode
+// NOTE: KEEP IN SYNC with src/hook.js:patchConsoleForInitialCommitInStrictMode
 export function patchForStrictMode() {
   if (consoleManagedByDevToolsDuringStrictMode) {
     const overrideConsoleMethods = [
@@ -359,7 +359,7 @@ export function patchForStrictMode() {
   }
 }
 
-// NOTE: KEEP IN SYNC with src/hook.js:unpatchConsoleForInitialRenderInStrictMode
+// NOTE: KEEP IN SYNC with src/hook.js:unpatchConsoleForInitialCommitInStrictMode
 export function unpatchForStrictMode(): void {
   if (consoleManagedByDevToolsDuringStrictMode) {
     if (unpatchForStrictModeFn !== null) {

diff --git a/packages/react-devtools-shared/src/hook.js b/packages/react-devtools-shared/src/hook.js
@@ -225,7 +225,7 @@ export function installHook(target: any): DevToolsHook | null {
   // React and DevTools are connecting and the renderer interface isn't avaiable
   // and we want to be able to have consistent logging behavior for double logs
   // during the initial renderer.
-  function patchConsoleForInitialRenderInStrictMode({
+  function patchConsoleForInitialCommitInStrictMode({
     hideConsoleLogsInStrictMode,
     browserTheme,
   }: {
@@ -311,7 +311,7 @@ export function installHook(target: any): DevToolsHook | null {
   }
 
   // NOTE: KEEP IN SYNC with src/backend/console.js:unpatchForStrictMode
-  function unpatchConsoleForInitialRenderInStrictMode() {
+  function unpatchConsoleForInitialCommitInStrictMode() {
     if (unpatchFn !== null) {
       unpatchFn();
       unpatchFn = null;
@@ -451,19 +451,19 @@ export function installHook(target: any): DevToolsHook | null {
         rendererInterface.unpatchConsoleForStrictMode();
       }
     } else {
-      // This should only happen during initial render in the extension before DevTools
+      // This should only happen during initial commit in the extension before DevTools
       // finishes its handshake with the injected renderer
       if (isStrictMode) {
         const hideConsoleLogsInStrictMode =
           window.__REACT_DEVTOOLS_HIDE_CONSOLE_LOGS_IN_STRICT_MODE__ === true;
         const browserTheme = window.__REACT_DEVTOOLS_BROWSER_THEME__;
 
-        patchConsoleForInitialRenderInStrictMode({
+        patchConsoleForInitialCommitInStrictMode({
           hideConsoleLogsInStrictMode,
           browserTheme,
         });
       } else {
-        unpatchConsoleForInitialRenderInStrictMode();
+        unpatchConsoleForInitialCommitInStrictMode();
       }
     }
   }