Revert "Skip over paths that don't include any insertions"

facebook · Aug 23, 2022 · 6b3de9f · 6b3de9f
1 parent c24c0a3
commit 6b3de9f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 12 deletions.
diff --git a/packages/react-reconciler/src/ReactFiberWorkLoop.new.js b/packages/react-reconciler/src/ReactFiberWorkLoop.new.js
@@ -3004,12 +3004,10 @@ function recursivelyTraverseAndDoubleInvokeEffectsInDEV(
   parentFiber: Fiber,
   isInStrictMode: boolean,
 ) {
-  if (parentFiber.subtreeFlags & PlacementDEV) {
-    let child = parentFiber.child;
-    while (child !== null) {
-      doubleInvokeEffectsInDEV(root, child, isInStrictMode);
-      child = child.sibling;
-    }
+  let child = parentFiber.child;
+  while (child !== null) {
+    doubleInvokeEffectsInDEV(root, child, isInStrictMode);
+    child = child.sibling;
   }
 }
 

diff --git a/packages/react-reconciler/src/ReactFiberWorkLoop.old.js b/packages/react-reconciler/src/ReactFiberWorkLoop.old.js
@@ -3004,12 +3004,10 @@ function recursivelyTraverseAndDoubleInvokeEffectsInDEV(
   parentFiber: Fiber,
   isInStrictMode: boolean,
 ) {
-  if (parentFiber.subtreeFlags & PlacementDEV) {
-    let child = parentFiber.child;
-    while (child !== null) {
-      doubleInvokeEffectsInDEV(root, child, isInStrictMode);
-      child = child.sibling;
-    }
+  let child = parentFiber.child;
+  while (child !== null) {
+    doubleInvokeEffectsInDEV(root, child, isInStrictMode);
+    child = child.sibling;
   }
 }