[Fizz] handle throwing after abort during render (#30730)

It is possible to throw after aborting during a render and we were not properly tracking this. We use an AbortSigil to mark whether a rendering task needs to abort but the throw interrupts that and we end up handling an error on the error pathway instead. This change reworks the abort-while-rendering support to be robust to throws after calling abort DiffTrain build for [7954db9](7954db9)
facebook · Aug 17, 2024 · 6f94ca8 · 6f94ca8
1 parent b41f0cd
commit 6f94ca8
Show file tree

Hide file tree

Showing 36 changed files with 148 additions and 147 deletions.
diff --git a/compiled/facebook-www/REVISION b/compiled/facebook-www/REVISION
@@ -1 +1 @@
-7e8a06cf4c628be45171da52c1a8e97f9869b7ee
+7954db9398b9afa962167577a6c6940be3856c39
diff --git a/compiled/facebook-www/REVISION_TRANSFORMS b/compiled/facebook-www/REVISION_TRANSFORMS
@@ -1 +1 @@
-7e8a06cf4c628be45171da52c1a8e97f9869b7ee
+7954db9398b9afa962167577a6c6940be3856c39
diff --git a/compiled/facebook-www/React-dev.classic.js b/compiled/facebook-www/React-dev.classic.js
@@ -2001,7 +2001,7 @@ __DEV__ &&
     exports.useTransition = function () {
       return resolveDispatcher().useTransition();
     };
-    exports.version = "19.0.0-www-classic-7e8a06cf-20240815";
+    exports.version = "19.0.0-www-classic-7954db93-20240816";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

diff --git a/compiled/facebook-www/React-dev.modern.js b/compiled/facebook-www/React-dev.modern.js
@@ -1981,7 +1981,7 @@ __DEV__ &&
     exports.useTransition = function () {
       return resolveDispatcher().useTransition();
     };
-    exports.version = "19.0.0-www-modern-7e8a06cf-20240815";
+    exports.version = "19.0.0-www-modern-7954db93-20240816";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

diff --git a/compiled/facebook-www/React-prod.classic.js b/compiled/facebook-www/React-prod.classic.js
@@ -665,4 +665,4 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.0.0-www-classic-7e8a06cf-20240815";
+exports.version = "19.0.0-www-classic-7954db93-20240816";
diff --git a/compiled/facebook-www/React-prod.modern.js b/compiled/facebook-www/React-prod.modern.js
@@ -665,4 +665,4 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.0.0-www-modern-7e8a06cf-20240815";
+exports.version = "19.0.0-www-modern-7954db93-20240816";
diff --git a/compiled/facebook-www/React-profiling.classic.js b/compiled/facebook-www/React-profiling.classic.js
@@ -669,7 +669,7 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.0.0-www-classic-7e8a06cf-20240815";
+exports.version = "19.0.0-www-classic-7954db93-20240816";
 "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
   "function" ===
     typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

diff --git a/compiled/facebook-www/React-profiling.modern.js b/compiled/facebook-www/React-profiling.modern.js
@@ -669,7 +669,7 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactSharedInternals.H.useTransition();
 };
-exports.version = "19.0.0-www-modern-7e8a06cf-20240815";
+exports.version = "19.0.0-www-modern-7954db93-20240816";
 "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
   "function" ===
     typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

diff --git a/compiled/facebook-www/ReactART-dev.classic.js b/compiled/facebook-www/ReactART-dev.classic.js
@@ -16776,11 +16776,11 @@ __DEV__ &&
     (function () {
       var internals = {
         bundleType: 1,
-        version: "19.0.0-www-classic-7e8a06cf-20240815",
+        version: "19.0.0-www-classic-7954db93-20240816",
         rendererPackageName: "react-art",
         currentDispatcherRef: ReactSharedInternals,
         findFiberByHostInstance: getInstanceFromNode,
-        reconcilerVersion: "19.0.0-www-classic-7e8a06cf-20240815"
+        reconcilerVersion: "19.0.0-www-classic-7954db93-20240816"
       };
       internals.overrideHookState = overrideHookState;
       internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -16814,7 +16814,7 @@ __DEV__ &&
     exports.Shape = Shape;
     exports.Surface = Surface;
     exports.Text = Text;
-    exports.version = "19.0.0-www-classic-7e8a06cf-20240815";
+    exports.version = "19.0.0-www-classic-7954db93-20240816";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

diff --git a/compiled/facebook-www/ReactART-dev.modern.js b/compiled/facebook-www/ReactART-dev.modern.js
@@ -16189,11 +16189,11 @@ __DEV__ &&
     (function () {
       var internals = {
         bundleType: 1,
-        version: "19.0.0-www-modern-7e8a06cf-20240815",
+        version: "19.0.0-www-modern-7954db93-20240816",
         rendererPackageName: "react-art",
         currentDispatcherRef: ReactSharedInternals,
         findFiberByHostInstance: getInstanceFromNode,
-        reconcilerVersion: "19.0.0-www-modern-7e8a06cf-20240815"
+        reconcilerVersion: "19.0.0-www-modern-7954db93-20240816"
       };
       internals.overrideHookState = overrideHookState;
       internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -16227,7 +16227,7 @@ __DEV__ &&
     exports.Shape = Shape;
     exports.Surface = Surface;
     exports.Text = Text;
-    exports.version = "19.0.0-www-modern-7e8a06cf-20240815";
+    exports.version = "19.0.0-www-modern-7954db93-20240816";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

diff --git a/compiled/facebook-www/ReactART-prod.classic.js b/compiled/facebook-www/ReactART-prod.classic.js
@@ -10618,13 +10618,13 @@ var slice = Array.prototype.slice,
   })(React.Component);
 var internals$jscomp$inline_1361 = {
   bundleType: 0,
-  version: "19.0.0-www-classic-7e8a06cf-20240815",
+  version: "19.0.0-www-classic-7954db93-20240816",
   rendererPackageName: "react-art",
   currentDispatcherRef: ReactSharedInternals,
   findFiberByHostInstance: function () {
     return null;
   },
-  reconcilerVersion: "19.0.0-www-classic-7e8a06cf-20240815"
+  reconcilerVersion: "19.0.0-www-classic-7954db93-20240816"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
   var hook$jscomp$inline_1362 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -10650,4 +10650,4 @@ exports.RadialGradient = RadialGradient;
 exports.Shape = TYPES.SHAPE;
 exports.Surface = Surface;
 exports.Text = Text;
-exports.version = "19.0.0-www-classic-7e8a06cf-20240815";
+exports.version = "19.0.0-www-classic-7954db93-20240816";
diff --git a/compiled/facebook-www/ReactART-prod.modern.js b/compiled/facebook-www/ReactART-prod.modern.js
@@ -10132,13 +10132,13 @@ var slice = Array.prototype.slice,
   })(React.Component);
 var internals$jscomp$inline_1353 = {
   bundleType: 0,
-  version: "19.0.0-www-modern-7e8a06cf-20240815",
+  version: "19.0.0-www-modern-7954db93-20240816",
   rendererPackageName: "react-art",
   currentDispatcherRef: ReactSharedInternals,
   findFiberByHostInstance: function () {
     return null;
   },
-  reconcilerVersion: "19.0.0-www-modern-7e8a06cf-20240815"
+  reconcilerVersion: "19.0.0-www-modern-7954db93-20240816"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
   var hook$jscomp$inline_1354 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -10164,4 +10164,4 @@ exports.RadialGradient = RadialGradient;
 exports.Shape = TYPES.SHAPE;
 exports.Surface = Surface;
 exports.Text = Text;
-exports.version = "19.0.0-www-modern-7e8a06cf-20240815";
+exports.version = "19.0.0-www-modern-7954db93-20240816";
diff --git a/compiled/facebook-www/ReactDOM-dev.classic.js b/compiled/facebook-www/ReactDOM-dev.classic.js
@@ -27528,11 +27528,11 @@ __DEV__ &&
         : flushSyncErrorInBuildsThatSupportLegacyMode;
     (function () {
       var isomorphicReactPackageVersion = React.version;
-      if ("19.0.0-www-classic-7e8a06cf-20240815" !== isomorphicReactPackageVersion)
+      if ("19.0.0-www-classic-7954db93-20240816" !== isomorphicReactPackageVersion)
         throw Error(
           'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n  - react:      ' +
             (isomorphicReactPackageVersion +
-              "\n  - react-dom:  19.0.0-www-classic-7e8a06cf-20240815\nLearn more: https://react.dev/warnings/version-mismatch")
+              "\n  - react-dom:  19.0.0-www-classic-7954db93-20240816\nLearn more: https://react.dev/warnings/version-mismatch")
         );
     })();
     ("function" === typeof Map &&
@@ -27576,11 +27576,11 @@ __DEV__ &&
       !(function () {
         var internals = {
           bundleType: 1,
-          version: "19.0.0-www-classic-7e8a06cf-20240815",
+          version: "19.0.0-www-classic-7954db93-20240816",
           rendererPackageName: "react-dom",
           currentDispatcherRef: ReactSharedInternals,
           findFiberByHostInstance: getClosestInstanceFromNode,
-          reconcilerVersion: "19.0.0-www-classic-7e8a06cf-20240815"
+          reconcilerVersion: "19.0.0-www-classic-7954db93-20240816"
         };
         internals.overrideHookState = overrideHookState;
         internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -28233,7 +28233,7 @@ __DEV__ &&
     exports.useFormStatus = function () {
       return resolveDispatcher().useHostTransitionStatus();
     };
-    exports.version = "19.0.0-www-classic-7e8a06cf-20240815";
+    exports.version = "19.0.0-www-classic-7954db93-20240816";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

diff --git a/compiled/facebook-www/ReactDOM-dev.modern.js b/compiled/facebook-www/ReactDOM-dev.modern.js
@@ -26613,11 +26613,11 @@ __DEV__ &&
       return_targetInst = null;
     (function () {
       var isomorphicReactPackageVersion = React.version;
-      if ("19.0.0-www-modern-7e8a06cf-20240815" !== isomorphicReactPackageVersion)
+      if ("19.0.0-www-modern-7954db93-20240816" !== isomorphicReactPackageVersion)
         throw Error(
           'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n  - react:      ' +
             (isomorphicReactPackageVersion +
-              "\n  - react-dom:  19.0.0-www-modern-7e8a06cf-20240815\nLearn more: https://react.dev/warnings/version-mismatch")
+              "\n  - react-dom:  19.0.0-www-modern-7954db93-20240816\nLearn more: https://react.dev/warnings/version-mismatch")
         );
     })();
     ("function" === typeof Map &&
@@ -26660,11 +26660,11 @@ __DEV__ &&
       !(function () {
         var internals = {
           bundleType: 1,
-          version: "19.0.0-www-modern-7e8a06cf-20240815",
+          version: "19.0.0-www-modern-7954db93-20240816",
           rendererPackageName: "react-dom",
           currentDispatcherRef: ReactSharedInternals,
           findFiberByHostInstance: getClosestInstanceFromNode,
-          reconcilerVersion: "19.0.0-www-modern-7e8a06cf-20240815"
+          reconcilerVersion: "19.0.0-www-modern-7954db93-20240816"
         };
         internals.overrideHookState = overrideHookState;
         internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -27269,7 +27269,7 @@ __DEV__ &&
     exports.useFormStatus = function () {
       return resolveDispatcher().useHostTransitionStatus();
     };
-    exports.version = "19.0.0-www-modern-7e8a06cf-20240815";
+    exports.version = "19.0.0-www-modern-7954db93-20240816";
     "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
       "function" ===
         typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

diff --git a/compiled/facebook-www/ReactDOM-prod.classic.js b/compiled/facebook-www/ReactDOM-prod.classic.js
@@ -17170,14 +17170,14 @@ function getCrossOriginStringAs(as, input) {
 }
 var isomorphicReactPackageVersion$jscomp$inline_1753 = React.version;
 if (
-  "19.0.0-www-classic-7e8a06cf-20240815" !==
+  "19.0.0-www-classic-7954db93-20240816" !==
   isomorphicReactPackageVersion$jscomp$inline_1753
 )
   throw Error(
     formatProdErrorMessage(
       527,
       isomorphicReactPackageVersion$jscomp$inline_1753,
-      "19.0.0-www-classic-7e8a06cf-20240815"
+      "19.0.0-www-classic-7954db93-20240816"
     )
   );
 function flushSyncFromReconciler(fn) {
@@ -17222,11 +17222,11 @@ Internals.Events = [
 ];
 var internals$jscomp$inline_2208 = {
   bundleType: 0,
-  version: "19.0.0-www-classic-7e8a06cf-20240815",
+  version: "19.0.0-www-classic-7954db93-20240816",
   rendererPackageName: "react-dom",
   currentDispatcherRef: ReactSharedInternals,
   findFiberByHostInstance: getClosestInstanceFromNode,
-  reconcilerVersion: "19.0.0-www-classic-7e8a06cf-20240815"
+  reconcilerVersion: "19.0.0-www-classic-7954db93-20240816"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
   var hook$jscomp$inline_2209 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -17682,4 +17682,4 @@ exports.useFormState = function (action, initialState, permalink) {
 exports.useFormStatus = function () {
   return ReactSharedInternals.H.useHostTransitionStatus();
 };
-exports.version = "19.0.0-www-classic-7e8a06cf-20240815";
+exports.version = "19.0.0-www-classic-7954db93-20240816";
diff --git a/compiled/facebook-www/ReactDOM-prod.modern.js b/compiled/facebook-www/ReactDOM-prod.modern.js
@@ -16544,14 +16544,14 @@ function getCrossOriginStringAs(as, input) {
 }
 var isomorphicReactPackageVersion$jscomp$inline_1724 = React.version;
 if (
-  "19.0.0-www-modern-7e8a06cf-20240815" !==
+  "19.0.0-www-modern-7954db93-20240816" !==
   isomorphicReactPackageVersion$jscomp$inline_1724
 )
   throw Error(
     formatProdErrorMessage(
       527,
       isomorphicReactPackageVersion$jscomp$inline_1724,
-      "19.0.0-www-modern-7e8a06cf-20240815"
+      "19.0.0-www-modern-7954db93-20240816"
     )
   );
 Internals.findDOMNode = function (componentOrElement) {
@@ -16569,11 +16569,11 @@ Internals.Events = [
 ];
 var internals$jscomp$inline_2199 = {
   bundleType: 0,
-  version: "19.0.0-www-modern-7e8a06cf-20240815",
+  version: "19.0.0-www-modern-7954db93-20240816",
   rendererPackageName: "react-dom",
   currentDispatcherRef: ReactSharedInternals,
   findFiberByHostInstance: getClosestInstanceFromNode,
-  reconcilerVersion: "19.0.0-www-modern-7e8a06cf-20240815"
+  reconcilerVersion: "19.0.0-www-modern-7954db93-20240816"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
   var hook$jscomp$inline_2200 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
@@ -16936,4 +16936,4 @@ exports.useFormState = function (action, initialState, permalink) {
 exports.useFormStatus = function () {
   return ReactSharedInternals.H.useHostTransitionStatus();
 };
-exports.version = "19.0.0-www-modern-7e8a06cf-20240815";
+exports.version = "19.0.0-www-modern-7954db93-20240816";
diff --git a/compiled/facebook-www/ReactDOM-profiling.classic.js b/compiled/facebook-www/ReactDOM-profiling.classic.js
@@ -17949,14 +17949,14 @@ function getCrossOriginStringAs(as, input) {
 }
 var isomorphicReactPackageVersion$jscomp$inline_1841 = React.version;
 if (
-  "19.0.0-www-classic-7e8a06cf-20240815" !==
+  "19.0.0-www-classic-7954db93-20240816" !==
   isomorphicReactPackageVersion$jscomp$inline_1841
 )
   throw Error(
     formatProdErrorMessage(
       527,
       isomorphicReactPackageVersion$jscomp$inline_1841,
-      "19.0.0-www-classic-7e8a06cf-20240815"
+      "19.0.0-www-classic-7954db93-20240816"
     )
   );
 function flushSyncFromReconciler(fn) {
@@ -18001,11 +18001,11 @@ Internals.Events = [
 ];
 var internals$jscomp$inline_1848 = {
   bundleType: 0,
-  version: "19.0.0-www-classic-7e8a06cf-20240815",
+  version: "19.0.0-www-classic-7954db93-20240816",
   rendererPackageName: "react-dom",
   currentDispatcherRef: ReactSharedInternals,
   findFiberByHostInstance: getClosestInstanceFromNode,
-  reconcilerVersion: "19.0.0-www-classic-7e8a06cf-20240815"
+  reconcilerVersion: "19.0.0-www-classic-7954db93-20240816"
 };
 enableSchedulingProfiler &&
   ((internals$jscomp$inline_1848.getLaneLabelMap = getLaneLabelMap),
@@ -18464,7 +18464,7 @@ exports.useFormState = function (action, initialState, permalink) {
 exports.useFormStatus = function () {
   return ReactSharedInternals.H.useHostTransitionStatus();
 };
-exports.version = "19.0.0-www-classic-7e8a06cf-20240815";
+exports.version = "19.0.0-www-classic-7954db93-20240816";
 "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
   "function" ===
     typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

diff --git a/compiled/facebook-www/ReactDOM-profiling.modern.js b/compiled/facebook-www/ReactDOM-profiling.modern.js
@@ -17306,14 +17306,14 @@ function getCrossOriginStringAs(as, input) {
 }
 var isomorphicReactPackageVersion$jscomp$inline_1812 = React.version;
 if (
-  "19.0.0-www-modern-7e8a06cf-20240815" !==
+  "19.0.0-www-modern-7954db93-20240816" !==
   isomorphicReactPackageVersion$jscomp$inline_1812
 )
   throw Error(
     formatProdErrorMessage(
       527,
       isomorphicReactPackageVersion$jscomp$inline_1812,
-      "19.0.0-www-modern-7e8a06cf-20240815"
+      "19.0.0-www-modern-7954db93-20240816"
     )
   );
 Internals.findDOMNode = function (componentOrElement) {
@@ -17331,11 +17331,11 @@ Internals.Events = [
 ];
 var internals$jscomp$inline_1814 = {
   bundleType: 0,
-  version: "19.0.0-www-modern-7e8a06cf-20240815",
+  version: "19.0.0-www-modern-7954db93-20240816",
   rendererPackageName: "react-dom",
   currentDispatcherRef: ReactSharedInternals,
   findFiberByHostInstance: getClosestInstanceFromNode,
-  reconcilerVersion: "19.0.0-www-modern-7e8a06cf-20240815"
+  reconcilerVersion: "19.0.0-www-modern-7954db93-20240816"
 };
 enableSchedulingProfiler &&
   ((internals$jscomp$inline_1814.getLaneLabelMap = getLaneLabelMap),
@@ -17701,7 +17701,7 @@ exports.useFormState = function (action, initialState, permalink) {
 exports.useFormStatus = function () {
   return ReactSharedInternals.H.useHostTransitionStatus();
 };
-exports.version = "19.0.0-www-modern-7e8a06cf-20240815";
+exports.version = "19.0.0-www-modern-7954db93-20240816";
 "undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
   "function" ===
     typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		7e8a06cf4c628be45171da52c1a8e97f9869b7ee
		7954db9398b9afa962167577a6c6940be3856c39