refactor: remove unnecessary judgment when check fragment props

facebook · Sep 5, 2018 · 7aef631 · 7aef631
1 parent 9a110eb
commit 7aef631
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/packages/react/src/ReactElement.js b/packages/react/src/ReactElement.js
@@ -64,6 +64,7 @@ function defineKeyPropWarningGetter(props, displayName) {
  Object.defineProperty(props, 'key', {
  get: warnAboutAccessingKey,
  configurable: true,
+ enumerable: false,
  });
 }
 
@@ -85,6 +86,7 @@ function defineRefPropWarningGetter(props, displayName) {
  Object.defineProperty(props, 'ref', {
  get: warnAboutAccessingRef,
  configurable: true,
+ enumerable: false,
  });
 }
 

diff --git a/packages/react/src/ReactElementValidator.js b/packages/react/src/ReactElementValidator.js
@@ -239,7 +239,7 @@ function validateFragmentProps(fragment) {
  const keys = Object.keys(fragment.props);
  for (let i = 0; i < keys.length; i++) {
  const key = keys[i];
- if (key !== 'children' && key !== 'key') {
+ if (key !== 'children') {
  warning(
  false,
  'Invalid prop `%s` supplied to `React.Fragment`. ' +