Skip to content

Commit

Permalink
Add test for no-primitive-constructors rule
Browse files Browse the repository at this point in the history
  • Loading branch information
acdlite committed Mar 1, 2017
1 parent 2f63b0d commit 7d5cc2e
Show file tree
Hide file tree
Showing 2 changed files with 51 additions and 1 deletion.
50 changes: 50 additions & 0 deletions eslint-rules/__tests__/no-primitive-constructors-test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
/**
* Copyright 2015-present, Facebook, Inc.
* All rights reserved.
*
* This source code is licensed under the BSD-style license found in the
* LICENSE file in the root directory of this source tree. An additional grant
* of patent rights can be found in the PATENTS file in the same directory.
*
* @emails react-core
*/

'use strict';

var rule = require('../no-primitive-constructors');
var RuleTester = require('eslint').RuleTester;
var ruleTester = new RuleTester();

ruleTester.run('eslint-rules/no-primitive-constructors', rule, {
valid: [
'!!obj',
"'' + obj",
'+string',
],
invalid: [
{
code: 'Boolean(obj)',
errors: [
{
message: 'Do not use the Boolean constructor. To cast a value to a boolean, use double negation: !!value',
},
],
},
{
code: 'String(obj)',
errors: [
{
message: 'Do not use the String constructor. To cast a value to a string, concat it with the empty string (unless it\'s a symbol, which has different semantics): \'\' + value',
},
],
},
{
code: 'Number(string)',
errors: [
{
message: 'Do not use the Number constructor. To cast a value to a number, use the plus operator: +value',
},
],
},
],
});
2 changes: 1 addition & 1 deletion eslint-rules/no-primitive-constructors.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ module.exports = function(context) {
node,
name,
'To cast a value to a string, concat it with the empty string ' +
'(unless it\'s a symbol, which have different semantics): ' +
'(unless it\'s a symbol, which has different semantics): ' +
'\'\' + value'
);
break;
Expand Down

0 comments on commit 7d5cc2e

Please sign in to comment.