Skip to content

Commit

Permalink
[Flight] Only skip past the end boundary if there is a newline charac…
Browse files Browse the repository at this point in the history
…ter (#26945)

Follow up to #26932

For regular rows, we're increasing the index by one to skip past the
last trailing newline character which acts a boundary. For length
encoded rows we shouldn't skip an extra byte because it'll leave us
missing one.

This only accidentally worked because this was also the end of the
current chunk which tests don't account for since we're just passing
through the chunks. So I added some noise by splitting and joining the
chunks so that this gets tested.

DiffTrain build for commit a1723e1.
  • Loading branch information
sebmarkbage committed Jun 14, 2023
1 parent 0d865f0 commit 8d784b2
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23922,7 +23922,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-canary-a7bf5ba61-20230613";
var ReactVersion = "18.3.0-canary-a1723e18f-20230614";

// Might add PROFILE later.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8617,7 +8617,7 @@ var devToolsConfig$jscomp$inline_1031 = {
throw Error("TestRenderer does not support findFiberByHostInstance()");
},
bundleType: 0,
version: "18.3.0-canary-a7bf5ba61-20230613",
version: "18.3.0-canary-a1723e18f-20230614",
rendererPackageName: "react-test-renderer"
};
var internals$jscomp$inline_1230 = {
Expand Down Expand Up @@ -8648,7 +8648,7 @@ var internals$jscomp$inline_1230 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-canary-a7bf5ba61-20230613"
reconcilerVersion: "18.3.0-canary-a1723e18f-20230614"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1231 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9043,7 +9043,7 @@ var devToolsConfig$jscomp$inline_1073 = {
throw Error("TestRenderer does not support findFiberByHostInstance()");
},
bundleType: 0,
version: "18.3.0-canary-a7bf5ba61-20230613",
version: "18.3.0-canary-a1723e18f-20230614",
rendererPackageName: "react-test-renderer"
};
var internals$jscomp$inline_1271 = {
Expand Down Expand Up @@ -9074,7 +9074,7 @@ var internals$jscomp$inline_1271 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-canary-a7bf5ba61-20230613"
reconcilerVersion: "18.3.0-canary-a1723e18f-20230614"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1272 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ if (
}
"use strict";

var ReactVersion = "18.3.0-canary-a7bf5ba61-20230613";
var ReactVersion = "18.3.0-canary-a1723e18f-20230614";

// ATTENTION
// When adding new symbols to this file,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -642,4 +642,4 @@ exports.useSyncExternalStore = function (
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-canary-a7bf5ba61-20230613";
exports.version = "18.3.0-canary-a1723e18f-20230614";
Original file line number Diff line number Diff line change
Expand Up @@ -645,7 +645,7 @@ exports.useSyncExternalStore = function (
);
};
exports.useTransition = useTransition;
exports.version = "18.3.0-canary-a7bf5ba61-20230613";
exports.version = "18.3.0-canary-a1723e18f-20230614";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
a7bf5ba614c6ddbd1eb3057c71f72efd1b6c21a9
a1723e18fd42e67d610adb0107c9015319613bd7

0 comments on commit 8d784b2

Please sign in to comment.