Skip to content

Commit

Permalink
Move HTML and SVG configs into DOMProperty (#11728)
Browse files Browse the repository at this point in the history
* Inline HTML and SVG configs into DOMProperty

* Replace invariants with warnings

These invariants can only happen if *we* mess up, and happen during init time.
So it's safe to make these warnings, as they would fail the tests anyway.

* Clearer variable naming
  • Loading branch information
gaearon authored Nov 30, 2017
1 parent b3e27b2 commit 8ec2ed4
Show file tree
Hide file tree
Showing 7 changed files with 266 additions and 337 deletions.
1 change: 0 additions & 1 deletion packages/react-dom/src/client/ReactDOM.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import type {
} from 'react-reconciler/src/ReactFiberRoot';

import '../shared/checkReact';
import '../shared/ReactDOMInjection';
import './ReactDOMClientInjection';

import ReactFiberReconciler from 'react-reconciler';
Expand Down
1 change: 0 additions & 1 deletion packages/react-dom/src/server/ReactDOMServerBrowser.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
* LICENSE file in the root directory of this source tree.
*/

import '../shared/ReactDOMInjection';
import ReactVersion from 'shared/ReactVersion';
import invariant from 'fbjs/lib/invariant';

Expand Down
1 change: 0 additions & 1 deletion packages/react-dom/src/server/ReactDOMServerNode.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
* LICENSE file in the root directory of this source tree.
*/

import '../shared/ReactDOMInjection';
import ReactVersion from 'shared/ReactVersion';

import {renderToString, renderToStaticMarkup} from './ReactDOMStringRenderer';
Expand Down
Loading

0 comments on commit 8ec2ed4

Please sign in to comment.