Skip to content

Commit

Permalink
[Fizz] Add proper assertion for stream fix (#27543)
Browse files Browse the repository at this point in the history
In #27541 I added tests to assert
that the write after close bug was fixed. However the Node
implementation has an abort behavior preventing reproduction of the
original issue and the Browser build does not use AsyncLocalStorage
which also prevents reproduction. This change moves the Browser test to
a Edge runtime where AsyncLocalStorage is polyfilled. In this
implementation the test does correctly fail when the patch is removed.

DiffTrain build for commit 9617d39.
  • Loading branch information
gnoff committed Oct 18, 2023
1 parent cd4934f commit 9e76446
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -24878,7 +24878,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-canary-601e5c385-20231018";
var ReactVersion = "18.3.0-canary-9617d39ec-20231018";

// Might add PROFILE later.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9022,7 +9022,7 @@ var devToolsConfig$jscomp$inline_1031 = {
throw Error("TestRenderer does not support findFiberByHostInstance()");
},
bundleType: 0,
version: "18.3.0-canary-601e5c385-20231018",
version: "18.3.0-canary-9617d39ec-20231018",
rendererPackageName: "react-test-renderer"
};
var internals$jscomp$inline_1224 = {
Expand Down Expand Up @@ -9053,7 +9053,7 @@ var internals$jscomp$inline_1224 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-canary-601e5c385-20231018"
reconcilerVersion: "18.3.0-canary-9617d39ec-20231018"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1225 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9448,7 +9448,7 @@ var devToolsConfig$jscomp$inline_1073 = {
throw Error("TestRenderer does not support findFiberByHostInstance()");
},
bundleType: 0,
version: "18.3.0-canary-601e5c385-20231018",
version: "18.3.0-canary-9617d39ec-20231018",
rendererPackageName: "react-test-renderer"
};
var internals$jscomp$inline_1265 = {
Expand Down Expand Up @@ -9479,7 +9479,7 @@ var internals$jscomp$inline_1265 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-canary-601e5c385-20231018"
reconcilerVersion: "18.3.0-canary-9617d39ec-20231018"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1266 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ if (
}
"use strict";

var ReactVersion = "18.3.0-canary-601e5c385-20231018";
var ReactVersion = "18.3.0-canary-9617d39ec-20231018";

// ATTENTION
// When adding new symbols to this file,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -580,4 +580,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-canary-601e5c385-20231018";
exports.version = "18.3.0-canary-9617d39ec-20231018";
Original file line number Diff line number Diff line change
Expand Up @@ -583,7 +583,7 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-canary-601e5c385-20231018";
exports.version = "18.3.0-canary-9617d39ec-20231018";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
601e5c38505ebc0ee099d8666b2f7a8b03159ac4
9617d39eca1fbac58afe73a23580d781ea20211d

0 comments on commit 9e76446

Please sign in to comment.