Add more test gating to fix broken targets

facebook · Apr 16, 2020 · c3a2c4b · c3a2c4b
1 parent 76f26f6
commit c3a2c4b
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 10 deletions.
diff --git a/packages/react-dom/src/__tests__/ReactDOMServerIntegrationModes-test.js b/packages/react-dom/src/__tests__/ReactDOMServerIntegrationModes-test.js
@@ -40,7 +40,10 @@ describe('ReactDOMServerIntegration', () => {
   });
 
   // Test pragmas don't support itRenders abstraction
-  if (require('shared/ReactFeatureFlags').enableDebugTracing) {
+  if (
+    __EXPERIMENTAL__ &&
+    require('shared/ReactFeatureFlags').enableDebugTracing
+  ) {
     describe('React.DebugTracingMode', () => {
       beforeEach(() => {
         spyOnDevAndProd(console, 'log');

diff --git a/packages/react-reconciler/src/__tests__/DebugTracing-test.internal.js b/packages/react-reconciler/src/__tests__/DebugTracing-test.internal.js
@@ -40,6 +40,7 @@ describe('DebugTracing', () => {
     });
   });
 
+  // @gate experimental
   it('should not log anything for sync render without suspends or state updates', () => {
     ReactTestRenderer.create(
       <React.DebugTracingMode>
@@ -50,8 +51,14 @@ describe('DebugTracing', () => {
     expect(logs).toEqual([]);
   });
 
+  // @gate experimental
   it('should not log anything for concurrent render without suspends or state updates', () => {
-    ReactTestRenderer.create(<div />, {unstable_isConcurrent: true});
+    ReactTestRenderer.create(
+      <React.DebugTracingMode>
+        <div />
+      </React.DebugTracingMode>,
+      {unstable_isConcurrent: true},
+    );
 
     expect(logs).toEqual([]);
 
@@ -62,7 +69,7 @@ describe('DebugTracing', () => {
     expect(logs).toEqual([]);
   });
 
-  // @gate enableDebugTracing
+  // @gate experimental && enableDebugTracing
   it('should log sync render with suspense', async () => {
     const fakeSuspensPromise = Promise.resolve(true);
     function Example() {
@@ -89,7 +96,7 @@ describe('DebugTracing', () => {
     expect(logs).toEqual(['log: ⚛️ Example resolved']);
   });
 
-  // @gate enableDebugTracing
+  // @gate experimental && enableDebugTracing
   it('should log concurrent render with suspense', async () => {
     const fakeSuspensPromise = Promise.resolve(true);
     function Example() {
@@ -123,7 +130,7 @@ describe('DebugTracing', () => {
     expect(logs).toEqual(['log: ⚛️ Example resolved']);
   });
 
-  // @gate enableDebugTracing
+  // @gate experimental && enableDebugTracing
   it('should log cascading class component updates', () => {
     class Example extends React.Component {
       state = {didMount: false};
@@ -157,7 +164,7 @@ describe('DebugTracing', () => {
     ]);
   });
 
-  // @gate enableDebugTracing
+  // @gate experimental && enableDebugTracing
   it('should log render phase state updates for class component', () => {
     class Example extends React.Component {
       state = {didRender: false};
@@ -192,7 +199,7 @@ describe('DebugTracing', () => {
     ]);
   });
 
-  // @gate enableDebugTracing
+  // @gate experimental && enableDebugTracing
   it('should log cascading layout updates', () => {
     function Example() {
       const [didMount, setDidMount] = React.useState(false);
@@ -224,7 +231,7 @@ describe('DebugTracing', () => {
     ]);
   });
 
-  // @gate enableDebugTracing
+  // @gate experimental && enableDebugTracing
   it('should log cascading passive updates', () => {
     function Example() {
       const [didMount, setDidMount] = React.useState(false);
@@ -249,7 +256,7 @@ describe('DebugTracing', () => {
     ]);
   });
 
-  // @gate enableDebugTracing
+  // @gate experimental && enableDebugTracing
   it('should log render phase updates', () => {
     function Example() {
       const [didRender, setDidRender] = React.useState(false);
@@ -275,7 +282,7 @@ describe('DebugTracing', () => {
     ]);
   });
 
-  // @gate enableDebugTracing
+  // @gate experimental && enableDebugTracing
   it('should log when user code logs', () => {
     function Example() {
       console.log('Hello from user code');
@@ -302,6 +309,7 @@ describe('DebugTracing', () => {
     ]);
   });
 
+  // @gate experimental
   it('should not log anything outside of a DebugTracingMode subtree', () => {
     function ExampleThatCascades() {
       const [didMount, setDidMount] = React.useState(false);