Skip to content

Commit

Permalink
[playground] Decouple playground from compiler
Browse files Browse the repository at this point in the history
Currently the playground is setup as a linked workspace for the
compiler which complicates our yarn workspace setup and means that snap
can sometimes pull in a different version of react than was otherwise
specified.

There's no real reason to have these workspaces combined so let's split
them up.

ghstack-source-id: ec2d5fb7721668772b76ddef36e399d09a47cf44
Pull Request resolved: #31081
  • Loading branch information
poteto committed Sep 26, 2024
1 parent 2bd9e4f commit ced1980
Show file tree
Hide file tree
Showing 5 changed files with 3,497 additions and 2,281 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/compiler_playground.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,4 @@ jobs:
key: ${{ runner.arch }}-${{ runner.os }}-modules-${{ hashFiles('compiler/**/yarn.lock') }}
- run: yarn install --frozen-lockfile
- run: npx playwright install --with-deps chromium
- run: yarn workspace playground test
- run: yarn test
12 changes: 12 additions & 0 deletions compiler/apps/playground/scripts/link-react-compiler-runtime.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
#!/usr/bin/env bash
# Copyright (c) Meta Platforms, Inc. and affiliates.
#
# This source code is licensed under the MIT license found in the
# LICENSE file in the root directory of this source tree.

set -eo pipefail

HERE=$(pwd)

cd ../../packages/react-compiler-runtime && yarn --silent link
cd $HERE && yarn --silent link react-compiler-runtime
Loading

0 comments on commit ced1980

Please sign in to comment.