Skip to content

Commit

Permalink
SchedulerPostTask: Reuse original TaskController (#27595)
Browse files Browse the repository at this point in the history
## Summary

It's not clear to me why we currently create a new TaskController in
`runTask` – ultimately, we use the same signal and priority from the
original created in `unstable_scheduleCallback`

## How did you test this change?
```
yarn test SchedulerPostTask
```

DiffTrain build for commit a17467e.
  • Loading branch information
noahlemen committed Nov 2, 2023
1 parent 84c52ec commit d3f3dc5
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -24901,7 +24901,7 @@ function createFiberRoot(
return root;
}

var ReactVersion = "18.3.0-canary-6bfc0e032-20231101";
var ReactVersion = "18.3.0-canary-a17467e7e-20231102";

// Might add PROFILE later.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9039,7 +9039,7 @@ var devToolsConfig$jscomp$inline_1033 = {
throw Error("TestRenderer does not support findFiberByHostInstance()");
},
bundleType: 0,
version: "18.3.0-canary-6bfc0e032-20231101",
version: "18.3.0-canary-a17467e7e-20231102",
rendererPackageName: "react-test-renderer"
};
var internals$jscomp$inline_1226 = {
Expand Down Expand Up @@ -9070,7 +9070,7 @@ var internals$jscomp$inline_1226 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-canary-6bfc0e032-20231101"
reconcilerVersion: "18.3.0-canary-a17467e7e-20231102"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1227 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9465,7 +9465,7 @@ var devToolsConfig$jscomp$inline_1075 = {
throw Error("TestRenderer does not support findFiberByHostInstance()");
},
bundleType: 0,
version: "18.3.0-canary-6bfc0e032-20231101",
version: "18.3.0-canary-a17467e7e-20231102",
rendererPackageName: "react-test-renderer"
};
var internals$jscomp$inline_1267 = {
Expand Down Expand Up @@ -9496,7 +9496,7 @@ var internals$jscomp$inline_1267 = {
scheduleRoot: null,
setRefreshHandler: null,
getCurrentFiber: null,
reconcilerVersion: "18.3.0-canary-6bfc0e032-20231101"
reconcilerVersion: "18.3.0-canary-a17467e7e-20231102"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1268 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ if (
}
"use strict";

var ReactVersion = "18.3.0-canary-6bfc0e032-20231101";
var ReactVersion = "18.3.0-canary-a17467e7e-20231102";

// ATTENTION
// When adding new symbols to this file,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -580,4 +580,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-canary-6bfc0e032-20231101";
exports.version = "18.3.0-canary-a17467e7e-20231102";
Original file line number Diff line number Diff line change
Expand Up @@ -583,7 +583,7 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactCurrentDispatcher.current.useTransition();
};
exports.version = "18.3.0-canary-6bfc0e032-20231101";
exports.version = "18.3.0-canary-a17467e7e-20231102";

/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
if (
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
6bfc0e032acc7e5ad6da2a09f3c4f47f3321da2c
a17467e7e2cd8947c595d1834889b5d184459f12

0 comments on commit d3f3dc5

Please sign in to comment.