Skip to content

Commit

Permalink
Bypass packages that are already published when confirmed by users (#…
Browse files Browse the repository at this point in the history
…26141)

## Summary

I ran into some two factor certification issue and had to resume the
publish script. However, this time if I confirmed the published package,
it will still try to publish the same version and fail. This is not
expected, and it blocks me from publishing the rest of the packages.

## How did you test this change?

I re-run the publish script after the change and successfully publish
the rest of the packages.

```
? Have you run the build-and-test script? Yes

✓ Checking NPM permissions for ryancat. 881 ms

? Please provide an NPM two-factor auth token: 278924


react-devtools version 4.27.2 has already been published.

? Is this expected (will skip react-devtools@4.27.2)? Yes


react-devtools-core version 4.27.2 has already been published.

? Is this expected (will skip react-devtools-core@4.27.2)? Yes

✓ Publishing package react-devtools-inline 23.1 secs

You are now ready to publish the extension to Chrome, Edge, and Firefox:
  https://fburl.com/publish-react-devtools-extensions

When publishing to Firefox, remember the following:
  Build id: 625690
  Git archive: ******
```
  • Loading branch information
ryancat authored Feb 10, 2023
1 parent c851022 commit d9e0485
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion scripts/devtools/publish-release.js
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,8 @@ async function publishToNPM() {
)} has already been published.`
);

await confirm('Is this expected?');
await confirm(`Is this expected (will skip ${npmPackage}@${version})?`);
continue;
}

if (DRY_RUN) {
Expand Down

0 comments on commit d9e0485

Please sign in to comment.