wrap new functions in feature flag

facebook · Oct 21, 2021 · dcf04a4 · dcf04a4
1 parent faf84fe
commit dcf04a4
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 0 deletions.
diff --git a/packages/react-reconciler/src/ReactFiberCacheComponent.new.js b/packages/react-reconciler/src/ReactFiberCacheComponent.new.js
@@ -73,6 +73,9 @@ const prevFreshCacheOnStack: StackCursor<Cache | null> = createCursor(null);
 // for retaining the cache once it is in use (retainCache), and releasing the cache
 // once it is no longer needed (releaseCache).
 export function createCache(): Cache {
+  if (!enableCache) {
+    return (null: any);
+  }
   const cache: Cache = {
     controller: new AbortController(),
     data: new Map(),
@@ -83,6 +86,9 @@ export function createCache(): Cache {
 }
 
 export function retainCache(cache: Cache) {
+  if (!enableCache) {
+    return;
+  }
   if (__DEV__) {
     if (cache.controller.signal.aborted) {
       console.warn(
@@ -96,6 +102,9 @@ export function retainCache(cache: Cache) {
 
 // Cleanup a cache instance, potentially freeing it if there are no more references
 export function releaseCache(cache: Cache) {
+  if (!enableCache) {
+    return;
+  }
   cache.refCount--;
   if (__DEV__) {
     if (cache.refCount < 0) {

diff --git a/packages/react-reconciler/src/ReactFiberCacheComponent.old.js b/packages/react-reconciler/src/ReactFiberCacheComponent.old.js
@@ -73,6 +73,9 @@ const prevFreshCacheOnStack: StackCursor<Cache | null> = createCursor(null);
 // for retaining the cache once it is in use (retainCache), and releasing the cache
 // once it is no longer needed (releaseCache).
 export function createCache(): Cache {
+  if (!enableCache) {
+    return (null: any);
+  }
   const cache: Cache = {
     controller: new AbortController(),
     data: new Map(),
@@ -83,6 +86,9 @@ export function createCache(): Cache {
 }
 
 export function retainCache(cache: Cache) {
+  if (!enableCache) {
+    return;
+  }
   if (__DEV__) {
     if (cache.controller.signal.aborted) {
       console.warn(
@@ -96,6 +102,9 @@ export function retainCache(cache: Cache) {
 
 // Cleanup a cache instance, potentially freeing it if there are no more references
 export function releaseCache(cache: Cache) {
+  if (!enableCache) {
+    return;
+  }
   cache.refCount--;
   if (__DEV__) {
     if (cache.refCount < 0) {

diff --git a/packages/react-reconciler/src/ReactFiberHooks.new.js b/packages/react-reconciler/src/ReactFiberHooks.new.js
@@ -2124,6 +2124,9 @@ function updateRefresh() {
 }
 
 function refreshCache<T>(fiber: Fiber, seedKey: ?() => T, seedValue: T) {
+  if (!enableCache) {
+    return;
+  }
   // TODO: Does Cache work in legacy mode? Should decide and write a test.
   // TODO: Consider warning if the refresh is at discrete priority, or if we
   // otherwise suspect that it wasn't batched properly.

diff --git a/packages/react-reconciler/src/ReactFiberHooks.old.js b/packages/react-reconciler/src/ReactFiberHooks.old.js
@@ -2124,6 +2124,9 @@ function updateRefresh() {
 }
 
 function refreshCache<T>(fiber: Fiber, seedKey: ?() => T, seedValue: T) {
+  if (!enableCache) {
+    return;
+  }
   // TODO: Does Cache work in legacy mode? Should decide and write a test.
   // TODO: Consider warning if the refresh is at discrete priority, or if we
   // otherwise suspect that it wasn't batched properly.