lint, gating, codes.json

facebook · Nov 30, 2021 · ea448a4 · ea448a4
1 parent be7b789
commit ea448a4
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 7 deletions.
diff --git a/packages/react-dom/src/__tests__/ReactDOMServerSelectiveHydration-test.internal.js b/packages/react-dom/src/__tests__/ReactDOMServerSelectiveHydration-test.internal.js
@@ -1240,6 +1240,7 @@ describe('ReactDOMServerSelectiveHydration', () => {
     });
   });
 
+  // @gate enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay
   it('replays event with null target when tree is dismounted', async () => {
     let suspend = false;
     let resolve;
@@ -1282,7 +1283,7 @@ describe('ReactDOMServerSelectiveHydration', () => {
     container.innerHTML = finalHTML;
     suspend = true;
 
-    const root = ReactDOM.hydrateRoot(container, <App />);
+    ReactDOM.hydrateRoot(container, <App />);
 
     const childDiv = container.firstElementChild;
     dispatchMouseHoverEvent(childDiv);

diff --git a/packages/react-dom/src/events/ReactDOMEventListener.js b/packages/react-dom/src/events/ReactDOMEventListener.js
@@ -189,7 +189,7 @@ function dispatchEventWithEnableCapturePhaseSelectiveHydrationWithoutDiscreteEve
   );
 
   // We can dispatch the event now
-  const blockedOnInst = isBlocked(blockedOn);
+  let blockedOnInst = isBlocked(blockedOn);
   if (!blockedOnInst) {
     clearIfContinuousEvent(domEventName, nativeEvent);
     dispatchEventForPluginEventSystem(
@@ -224,7 +224,6 @@ function dispatchEventWithEnableCapturePhaseSelectiveHydrationWithoutDiscreteEve
     eventSystemFlags & IS_CAPTURE_PHASE &&
     isDiscreteEventThatRequiresHydration(domEventName)
   ) {
-    let blockedOnInst = isBlocked(blockedOn);
     while (blockedOnInst) {
       const fiber = getInstanceFromNode(blockedOnInst);
       if (fiber !== null) {

diff --git a/packages/react-dom/src/events/ReactDOMEventReplaying.js b/packages/react-dom/src/events/ReactDOMEventReplaying.js
@@ -513,7 +513,7 @@ function replayUnblockedEvents() {
     while (queuedDiscreteEvents.length > 0) {
       const nextDiscreteEvent = queuedDiscreteEvents[0];
       const blockedOn = nextDiscreteEvent.blockedOn;
-      let blockedOnInst = isBlocked(blockedOn);
+      const blockedOnInst = isBlocked(blockedOn);
       if (blockedOnInst) {
         // We're still blocked.
         // Increase the priority of this boundary to unblock

diff --git a/packages/react-dom/src/events/replayedEvent.js b/packages/react-dom/src/events/replayedEvent.js
@@ -19,8 +19,8 @@ export function replayEventWrapper(event: AnyNativeEvent, replay: () => void) {
     // the initial unblocking since we'll just dispatch it directly without queueing it
     // for replay.
     throw new Error(
-      'Attempting to replay event that is already replaying.' +
-        'This should never happen. This is a bug in React',
+      'Attempting to replay event that is already replaying. ' +
+        'This should never happen. This is a bug in React.',
     );
   }
   eventsReplaying.add(event);

diff --git a/scripts/error-codes/codes.json b/scripts/error-codes/codes.json
@@ -403,5 +403,6 @@
   "415": "Error parsing the data. It's probably an error code or network corruption.",
   "416": "This environment don't support binary chunks.",
   "417": "React currently only supports piping to one writable stream.",
-  "418": "An error occurred during hydration. The server HTML was replaced with client content"
+  "418": "An error occurred during hydration. The server HTML was replaced with client content",
+  "419": "Attempting to replay event that is already replaying. This should never happen. This is a bug in React."
 }