Update test

facebook · Mar 27, 2024 · f01dd3d · f01dd3d
1 parent 0ad2574
commit f01dd3d
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 15 deletions.
diff --git a/packages/react-dom/src/__tests__/ReactComponent-test.js b/packages/react-dom/src/__tests__/ReactComponent-test.js
@@ -26,17 +26,25 @@ describe('ReactComponent', () => {
     act = require('internal-test-utils').act;
   });
 
-  // @gate !disableLegacyMode
+  // @gate !disableLegacyMode && www
   it('should throw on invalid render targets in legacy roots', () => {
     const container = document.createElement('div');
     // jQuery objects are basically arrays; people often pass them in by mistake
-    expect(function () {
-      ReactDOM.render(<div />, [container]);
-    }).toThrowError(/Target container is not a DOM element./);
-
-    expect(function () {
-      ReactDOM.render(<div />, null);
-    }).toThrowError(/Target container is not a DOM element./);
+    expect(() => {
+      expect(function () {
+        ReactDOM.render(<div />, [container]);
+      }).toThrowError(/Target container is not a DOM element./);
+
+      expect(function () {
+        ReactDOM.render(<div />, null);
+      }).toThrowError(/Target container is not a DOM element./);
+    }).toErrorDev(
+      [
+        'ReactDOM.render is no longer supported in React 18.',
+        'ReactDOM.render is no longer supported in React 18.',
+      ],
+      {withoutStack: true},
+    );
   });
 
   // @gate !disableStringRefs
@@ -456,16 +464,25 @@ describe('ReactComponent', () => {
     /* eslint-enable indent */
   });
 
-  // @gate !disableLegacyMode
+  // @gate !disableLegacyMode && www
   it('fires the callback after a component is rendered in legacy roots', () => {
     const callback = jest.fn();
     const container = document.createElement('div');
-    ReactDOM.render(<div />, container, callback);
-    expect(callback).toHaveBeenCalledTimes(1);
-    ReactDOM.render(<div className="foo" />, container, callback);
-    expect(callback).toHaveBeenCalledTimes(2);
-    ReactDOM.render(<span />, container, callback);
-    expect(callback).toHaveBeenCalledTimes(3);
+    expect(() => {
+      ReactDOM.render(<div />, container, callback);
+      expect(callback).toHaveBeenCalledTimes(1);
+      ReactDOM.render(<div className="foo" />, container, callback);
+      expect(callback).toHaveBeenCalledTimes(2);
+      ReactDOM.render(<span />, container, callback);
+      expect(callback).toHaveBeenCalledTimes(3);
+    }).toErrorDev(
+      [
+        'ReactDOM.render is no longer supported in React 18.',
+        'ReactDOM.render is no longer supported in React 18.',
+        'ReactDOM.render is no longer supported in React 18.',
+      ],
+      {withoutStack: true},
+    );
   });
 
   it('throws usefully when rendering badly-typed elements', async () => {

diff --git a/packages/react-test-renderer/src/__tests__/ReactTestRenderer-test.internal.js b/packages/react-test-renderer/src/__tests__/ReactTestRenderer-test.internal.js
@@ -98,6 +98,8 @@ describe('ReactTestRenderer', () => {
         null,
         expect.anything(),
         expect.anything(),
+        expect.anything(),
+        expect.anything(),
         null,
       );
     }