Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Come up with a convention for forcing bin/jsx rebuilds without manually clearing .module-cache #104

Closed
benjamn opened this issue Jun 17, 2013 · 0 comments · Fixed by #535
Assignees

Comments

@benjamn
Copy link
Contributor

benjamn commented Jun 17, 2013

cc @petehunt @zpao

@ghost ghost assigned benjamn Jun 17, 2013
benjamn added a commit to benjamn/react that referenced this issue Dec 4, 2013
Pull request facebook#526 updated the behavior of vendor/constants.js without
changing any source files or the bin/jsx-internal script, so files that
should have been rebuilt (like utils/__tests__/ImmutableObject-test.js)
were not automatically rebuilt (unless you knew to do `grunt clean` or
`rm -rf .module-cache` manually).

This commit allows us to bump a version number when we know the transform
toolchain has been altered in a way that will not be visible to
commoner/jsx.

With this convention, if we reset to an older revision (e.g. during a git
bisect) and the appropriate cached module files are still in the
.module-cache/, they can be used without rebuilding. That's why I prefer
this approach to just deleting the .module-cache/.

Closes facebook#104.
Closes facebook#496.
Closes facebook#530.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant