Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate "Render methods should be pure" warning #11081

Closed
gaearon opened this issue Oct 4, 2017 · 5 comments
Closed

Deduplicate "Render methods should be pure" warning #11081

gaearon opened this issue Oct 4, 2017 · 5 comments
Labels
Component: Core Utilities Type: Enhancement

Comments

@gaearon
Copy link
Collaborator

gaearon commented Oct 4, 2017 •
edited
Loading

Note: the task is already claimed.

Just saw this in a fiddle that has a nested update bug:

screen shot 2017-10-04 at 11 52 52

It would be nice to just dedupe them in the first place instead of calling console.error a thousand times.

Note: the task is already claimed.
@gaearon gaearon mentioned this issue Oct 4, 2017
Closed
@gaearon
Copy link
Collaborator Author

gaearon commented Oct 4, 2017

Same for this one:

screen shot 2017-10-04 at 11 54 11

@imanushree
Copy link

I am interested in taking this up. This would be one of my first open source contributions and I am really excited about it :)

@gaearon
Copy link
Collaborator Author

gaearon commented Oct 4, 2017

Sounds great! You'll need to search the codebase to find where we fire these two warnings, and then add boolean variables for each. If we fire it once, we set a boolean. Next time we check a boolean before firing it, and skip if the boolean is already set.

@gaearon
Copy link
Collaborator Author

gaearon commented Oct 4, 2017

If you have any questions feel free to ping me here.

@gaearon gaearon mentioned this issue Oct 4, 2017
Closed
imanushree added a commit to imanushree/react that referenced this issue Oct 5, 2017
@imanushree
Deduplication of warning messages in nested updates (facebook#11081)
f06d412
@CharlesMangwa CharlesMangwa mentioned this issue Oct 5, 2017
Closed
@imanushree imanushree mentioned this issue Oct 6, 2017
Closed
@gaearon
Copy link
Collaborator Author

gaearon commented Oct 6, 2017

Fixed in #11113.

@gaearon gaearon closed this as completed Oct 6, 2017
gaearon pushed a commit that referenced this issue Oct 6, 2017
@anushreesubramani @gaearon
Deduplication of warning messages in nested updates (#11081) (#11113)
e862966
@gaearon gaearon mentioned this issue Oct 6, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Core Utilities Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gaearon @imanushree