Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warning code shows up in min build #1120

Closed
sophiebits opened this issue Feb 18, 2014 · 2 comments · Fixed by #1122
Closed

warning code shows up in min build #1120

sophiebits opened this issue Feb 18, 2014 · 2 comments · Fixed by #1122
Milestone
0.9

Comments

@sophiebits
Copy link
Collaborator

See http://fb.me/react-0.9.0-rc1.min.js and search for "Invalid. We should either (a) change warning's implementation to warn only in __DEV__ and strip it in the build step or (b) change the callers to check __DEV__.

@cpojer?
@sophiebits sophiebits added this to the 0.9 milestone Feb 18, 2014
@sophiebits
Copy link
Collaborator Author

(I think the functions that have the warnings aren't actually executed, but we should at least avoid including the warning message.)

@zpao
Copy link
Member

zpao commented Feb 18, 2014

I think we should just make warning look identical to invariant, then do the same thing we do in constants.js

@sophiebits sophiebits mentioned this issue Feb 18, 2014
Merged
sophiebits added a commit to sophiebits/react that referenced this issue Feb 18, 2014
@sophiebits
Strip calls to warning() in __DEV__
5795376 
Fixes facebook#1120.
zpao added a commit that referenced this issue Feb 18, 2014
@zpao
Merge pull request #1122 from spicyj/gh-1120
c79974d 
Strip calls to warning() in __DEV__
This was referenced Nov 5, 2022
Open
Open
Open
This was referenced Dec 25, 2022
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9
Development

Successfully merging a pull request may close this issue.

Strip calls to warning() in __DEV__ sophiebits/react
2 participants
@sophiebits @zpao