-
Notifications
You must be signed in to change notification settings - Fork 47.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress message: "Download the React DevTools for ..." #12041
Comments
You can star this issue and ask the Chrome team to fix it. There's nothing we can do unfortunately, it's caused by a Chrome regression.
You can see from the source code that the condition should exit before that log if I just created a project with Create React App, ejected it, and then added new webpack.DefinePlugin({
'__REACT_DEVTOOLS_GLOBAL_HOOK__': '({ isDisabled: true })'
}), to the configuration. It removed the log for me. So we'll need a reproducing project if you say it doesn't work. |
Wow, quick response. I'll try to get a reproducible project up tomorrow. |
Thanks! |
Okay, my bad, This newer react-dom package did contain the feature from PR #11448 . Thank you (and thanks for Redux :) ). And apologies for the false issue. Perhaps it's worth updating your comment in issue #3877 so it states react-dom should be >= 16.1.0. |
Ah okay. For the reference, we always recommend matching versions of all React packages. |
Any way to get rid of this message in RollupJS? |
feature/bug
What is the current behavior?
React library logs either "Download the React DevTools for a better development experience: https://fb.me/react-devtools" or logs "Warning: The installed version of React DevTools is too old and will not work with the current version of React. Please update React DevTools. https://fb.me/react-devtools" if previous "fix" is employed.
reproduce
Run React site without production flag and without React DevTools extension installed.
What is the expected behavior?
No log output.
Which versions of React
React: 16.2.0
Tried
According to comment on #3877 the following should work in React >= 16.1.0.
However this changes the log to:
"Warning: The installed version of React DevTools is too old and will not work with the current version of React. Please update React DevTools. https://fb.me/react-devtools"
Other fixes such as those from StackOverflow yield the same results: https://stackoverflow.com/a/42196820.
Also the plugin itself doesn't work for me because of facebook/react-devtools#897. So installing it isn't an option, for me at least.
TLDR
I'm loving React. But logging the install note is a tad annoying. Previous fixes don't seem to work. So please provide an option to disable the log.
The text was updated successfully, but these errors were encountered: