Expose component stack from reactTag to React Native renderer #12549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not safe in general and therefore shouldn't be exposed to anything other than React Native internals. It will also need a different version in Fabric that will not have the reactTag exposed.
sebmarkbage
force-pushed
the
componentstackbyreacttag
branch
from
389acdf
to
8ac92ef
Compare
gaearon
approved these changes
Apr 5, 2018
This was referenced Apr 17, 2018
This was referenced Apr 19, 2018
rhagigi
pushed a commit
to rhagigi/react
that referenced
this pull request
Apr 19, 2018
…ok#12549) This is not safe in general and therefore shouldn't be exposed to anything other than React Native internals. It will also need a different version in Fabric that will not have the reactTag exposed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not safe in general and therefore shouldn't be exposed to anything
other than React Native internals.
It will also need a different version in Fabric that will not have the
reactTag exposed.