🚀 Update dependencies: Thu Apr 19 14:50:47 UTC 2018 #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Updated depedencies:
react ^15.0.0 → 16.3.2
.16.3.2 / 2018-04-16
This was temporarily necessary in the past because we didn't have the logic that downloads actual merge base stats.
We do have that now as part of the Danger script. So we can remove this.
what is the change?:
Changes the expiration deadline from 500ms to 150ms, only in production.
In development it will still be 500ms.
I'm thinking we may want to change the 'bucket size' too, will look into
that a bit.
why make this change?:
We need to ensure interactions are responsive enough in order to gather
more test data on async. mode.
test plan:
No tests failed - where shall we add a test for this?
oops
This is just like ReactDOM does it. This also lets us get rid of injection
for findNodeHandle. Instead I move NativeMethodsMixin and ReactNativeComponent
to use instantiation.
The reconciler shouldn't expose the Fiber data structure. We should pass
the component instance to the reconciler, since the reconciler is the
thing that is supposed to be instancemap aware.
This ensures that both Fabric and RN renderers share the same view config
registry since it is stateful.
I had to duplicate in the mocks for testing.
Since createReactNativeComponentClass is just an alias for the register
there's no need to bundle it. This file should probably just move back
to RN too.
We already have one stateful module that contains all the view config.
We might as well store the event types there too. That way the shared
state is compartmentalized (and I can move it out in a follow up PR).
The view config registry also already has an appropriate place to call
processEventTypes so now we no longer have to do it in RN.
Will follow up with a PR to RN to remove that call.
These don't make much sense in Fabric, since Fabric will be async by default only.
And unmount+remove container is a sketchy API we should remove so we might
as well make sure modern containers enforce that.
This has always been an unnecessary indirection to protect opaqueness,
which hasn't really worked out.
Took this opportunity to remove some abstract overhead.
In Fabric it is extra simple since they no longer overlap with root tags.
This reverts commit 273370758eafa54d329577b3dc942c70587eccd3.
It only uses public APIs. I have a diff on the other side.
This doesn't actually need to share any state because it goes through
the instance to the fiber structure. Since Fabric is on the same version
as RN, calling it on either renderer works.
There are no plans to enable async in the old renderer. In the new renderer
it only really makes sense to do from the main thread and probably from
native since it'll have to yield to native first.
This isn't used by React core and is just a pure helper so it might as
well live where it's used. The React Native repo.
This is not safe in general and therefore shouldn't be exposed to anything
other than React Native internals.
It will also need a different version in Fabric that will not have the
reactTag exposed.
yarn prettier
Without it, doesn't do anything because we bail out on constant element anyway.
That's not what we're testing, and could be confusing.
lodash ^3.0.0 → 4.17.5
.4.17.5 / 2018-02-04
cloneWith
customizer. [closes #3582]Uses rAF by default for debounce/throtte unless
wait
is specified. (#3560)This adds the webpack v4 sideEffects optimization. Since we are now in alpha I wanted to help ensure this gets out there so people testing webpack v4 can see the instant wins. <3
createMathOperation
. (#3499)map
examples fromparseInt
andtrim
(#3487)createMathOperation
.escapeRegExp
(#3448)"This reverts commit 102d9e34d71838c027b5fc3d9153187f50842c95.
Faster/simpler isPlainObject check.
This runs up the prototype chain to check equivalency. When run in a cross-realm environment (differing contexts, iframes, etc), this ensures we're checking the value's prototype matches its context-specific instance of Object.
This is faster than calling
toString()
on the constructor. There's still thebaseGetTag()
call, which does its owntoString()
, but this swaps out one for cross-realm stuff. It's also a bit simpler to understand, I think.inRange
(#3478)escapeRegExp
(#3448)parseInt
(#3433)sortedUniq
.dropRight
.'T' missing in This.
Bitmask is number
stringToPath
(to close #3308).clarify that sortedUniq only works on sorted arrays
related lodash/lodash@e908519
invertBy
.invert
.string
variable declared in upper scopeThis starting returning NaN for me. It looks like it is trying to add undefined + number when there is no prefix.
set
. [closes #3189]tag
scope inbaseClone
.baseClone
.setToString
(c6854fa).repeat
import.filter
imports.Array#splice
directly.mergeData
.some
andevery
imports.map
imports.baseSlice
.find
.baseKeys
andbaseKeysIn
.filter
out.mapKey
andmapValue
.map
out.every
andsome
.mapKeys
andmapValues
tomapKey
andmapValue
.style
npm script execution (#3103).This rule can help catch errors introduced by automatic semicolon insertion
edge cases. It seems like a sensible thing to have enabled in a code base that
does not use semicolons.
http://eslint.org/docs/rules/no-unexpected-multiline
someValues
tosomeValue
.every
intoeveryValue
.toSource
.hasPath
.hasPath
.hasPath
andhasPathIn
.repeat
.someValues
(571e752).baseSum
(3e2b0bb).replaceHolders
.someObj
tosomeValues
.find
implementation.semi
option to eslint config..