Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only fail travis for phantomjs #1496

Closed
zpao opened this issue May 8, 2014 · 1 comment · Fixed by #1563
Closed

Only fail travis for phantomjs #1496

zpao opened this issue May 8, 2014 · 1 comment · Fixed by #1563
Labels
Component: Build Infrastructure

Comments

@zpao
Copy link
Member

zpao commented May 8, 2014

Our sauce setup isn't reliable enough to depend on it as a strong signal. For example, https://travis-ci.org/facebook/react/jobs/24732659 failed though all tests passed in phantom.
@sophiebits
Copy link
Collaborator

Would be nice if we could fail if tests actually fail but not when they time out like they seem to do often.

@sophiebits sophiebits mentioned this issue May 19, 2014
Merged
sophiebits added a commit to sophiebits/react that referenced this issue May 19, 2014
@sophiebits
Don't fail Travis on sauce failures
8db8e60 
Fixes facebook#1496.
@heshamelmasry77 heshamelmasry77 mentioned this issue Jul 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Build Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't fail Travis on sauce failures sophiebits/react
2 participants
@sophiebits @zpao