Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onMouseEnter is fired on disabled buttons #17229

Closed
diegohaz opened this issue Oct 30, 2019 · 4 comments
Closed

onMouseEnter is fired on disabled buttons #17229

diegohaz opened this issue Oct 30, 2019 · 4 comments

Comments

@diegohaz
Copy link

Do you want to request a feature or report a bug?

bug

What is the current behavior?

onMouseEnter is fired on disabled buttons.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn't have dependencies other than React. Paste the link to your JSFiddle (https://jsfiddle.net/Luktwrdm/) or CodeSandbox (https://codesandbox.io/s/new) example below:

https://codesandbox.io/s/react-onmouseenter-on-disabled-buttons-fskwd

What is the expected behavior?

onMouseEnter shouldn't be triggered on disabled buttons.

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?

React 16.11.0 (not sure when it started to happen)
Chrome/MacOS

@edwincoronado
Copy link

Taking a look at this to see if I can fix it.

@abrahamwilliam
Copy link

@edwincoronado @diegohaz

I have identified the fix to this issue/Bug, just testing it.I am proceeding to it, please let me know if any issues.

@AlfredoGJ
Copy link
Contributor

I submitted a pull request that solves this problem. If someone wants to take a look. Feedback is welcome.

@gaearon
Copy link
Collaborator

gaearon commented Feb 26, 2020

Should be fixed in 16.13.
https://reactjs.org/blog/2020/03/02/react-v16.13.0.html

@gaearon gaearon closed this as completed Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants