Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Dev Tools Standalone only draggable, not clickable #17522

Closed
mbman opened this issue Dec 4, 2019 · 5 comments
Closed

React Dev Tools Standalone only draggable, not clickable #17522

mbman opened this issue Dec 4, 2019 · 5 comments

Comments

@mbman
Copy link

mbman commented Dec 4, 2019

Do you want to request a feature or report a bug?
I want to report a bug.

What is the current behavior?

When running react-devtools standalone on Windows 10, they manage to connect to the React app, but the UI can't be clicked and clicking on it only drags the window. This makes it unusable.

I've debuged it using built-in Chrome dev tools and it's due to -webkit-app-region: drag applied to body and other elements. As soon as I override this to be -webkit-app-region: none; everything starts working fine - you can click on things and you can still drag the window.

What is the expected behavior?
Clicking on the UI should work and not only drag the window.

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?

I've tested it with React Dev Tools standalone version 4.2.1-3816ae7c3

@hristo-kanchev
Copy link
Contributor

I went through the PRs that were merged after the 4.2.0 release and from what I can see this might be causing the issue -> https://github.com/facebook/react/pull/17213/files#diff-0f549815d0bbdc6626381ce99a584450R100

I'm super busy at the moment, so I'll probably not be able to fix this bug myself.

Any takers? 😸

@hristo-kanchev
Copy link
Contributor

hristo-kanchev commented Dec 10, 2019

I can't seem to reproduce it on a Mac (latest master build) 🤔

@cwatson88
Copy link
Contributor

@hristo-kanchev happy to put a PR in, it can be found here: #17584
@mbman was correct in the post above, we have experienced this in the past in our product too.
Hope it helps 😄

@bvaughn
Copy link
Contributor

bvaughn commented Dec 29, 2019

Fixed via PR #17584

@bvaughn bvaughn closed this as completed Dec 29, 2019
@bvaughn
Copy link
Contributor

bvaughn commented Jan 3, 2020

FYI this issue should be fixed in v4.4 (released today)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants