Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduling profiler tweaks #20202

Closed
bvaughn opened this issue Nov 9, 2020 · 0 comments · Fixed by #20215
Closed

Scheduling profiler tweaks #20202

bvaughn opened this issue Nov 9, 2020 · 0 comments · Fixed by #20215

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Nov 9, 2020

Make the enableSchedulingProfiler flag dynamic for the profiling build (so marks can be disabled). I think it should be sufficient to do something like:

export const enableSchedulingProfiler =
  __PROFILE__ && dynamicFeatureFlags.enableSchedulingProfiler;

Update our User Timing API check to include clearMeasures and when we call mark(name), also call clearMeasures(name) to avoid clogging the entries buffer. (Apparently this has a significant negative performance impact for Firefox.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant