-
Notifications
You must be signed in to change notification settings - Fork 47.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No support for the svg stroke-linejoin attribute #2103
Labels
Comments
Please submit this to #1657 instead. |
This should be fixed by #5714. |
This was referenced Jul 27, 2021
This was referenced Sep 15, 2021
This was referenced Apr 7, 2022
This was referenced Jan 4, 2023
josephsavona
added a commit
that referenced
this issue
May 15, 2024
This is a redo of #1640 now that we've established the necessary infrastructure, most notably `Effect.ConditionallyMutate` and `noAlias` from #2103 earlier in this stack. We can now understand the semantics of hooks that return deeply readonly values composed of primitives, arrays, or objects such that any `.map()` or `.filter()` calls are guaranteed to be the corresponding array methods. That further allows us to refine, since we know that the lambdas passed to these calls can't alias, are conditionally mutable, etc. All in all this should let us memoize less in practice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently there is no support for the
stroke-linejoin
attribute on svg elements. Thestroke-linecap
has been implemented, but the line join is just as important.You can see the difference here; http://jsbin.com/vipowiqebipa/6/edit
The text was updated successfully, but these errors were encountered: