Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DevTools] Skip loading and parsing source for unnamed built-in hooks #21834

Closed
bvaughn opened this issue Jul 8, 2021 · 0 comments · Fixed by #21835
Closed

[DevTools] Skip loading and parsing source for unnamed built-in hooks #21834

bvaughn opened this issue Jul 8, 2021 · 0 comments · Fixed by #21835
Assignees
@bvaughn
Labels
Component: Developer Tools

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Jul 8, 2021

Hooks like useEffect or useLayoutEffect will never have names, so if a the only hooks for a given source file are these "unnamed" built-in hooks, we should skip loading the source code.
@bvaughn bvaughn mentioned this issue Jul 8, 2021
Closed
@bvaughn bvaughn changed the title DevTools: Skip loading and parsing source for unnamed built-in hooks [DevTools]: Skip loading and parsing source for unnamed built-in hooks Jul 8, 2021
@bvaughn bvaughn self-assigned this Jul 8, 2021
@bvaughn bvaughn mentioned this issue Jul 8, 2021
Merged
@bvaughn bvaughn changed the title [DevTools]: Skip loading and parsing source for unnamed built-in hooks [DevTools] Skip loading and parsing source for unnamed built-in hooks Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bvaughn bvaughn

Labels
Component: Developer Tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DevTools: Don't load source files contaning only unnamed hooks bvaughn/react
1 participant
@bvaughn