-
Notifications
You must be signed in to change notification settings - Fork 46.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: React dev tools inspect element of hover does not work on shadow elements #26200
Comments
@lunaruan could you guide me towards how to build the dev tools locally and test it with the changes after making? i have some idea to work on this problem cc @mondaychen |
To begin with, please follow https://github.com/facebook/react/blob/main/packages/react-devtools/CONTRIBUTING.md |
@mondaychen still kinda confused say i want to test the devtools changes locally within a react app how should i do so? |
@Biki-das if it's not extension specific, you can start the inline devtools server in react-devtools-inline, then start the shell in react-devtools-shell. Then you can test your changes with the shell UI. The guide: |
@mondaychen it's extension specific |
Then you go to react-devtools-extensions and run Can you read through the guide I sent you fist? Everything I'm talking about now is on it. |
@mondaychen getting this errors while trying to run the extension anything i might be doing wrong? |
Fixes #26200 ### PR explanation I tried to induce the change by the `event.composed` to check whether the event was created in a ShadowRoot, And replaced `pointerOver` with `pointerMove`, pointerOver event did not fired correctly Before PR:- https://github.com/facebook/react/assets/72331432/67a33dcd-447f-4c68-9c3c-ad954baddeb8 After PR:- https://github.com/facebook/react/assets/72331432/9f986ff2-785f-4cba-a504-44f82ea9fc5a --------- Co-authored-by: Biki das <bikidas@Bikis-MacBook-Pro.local>
Fixes facebook#26200 ### PR explanation I tried to induce the change by the `event.composed` to check whether the event was created in a ShadowRoot, And replaced `pointerOver` with `pointerMove`, pointerOver event did not fired correctly Before PR:- https://github.com/facebook/react/assets/72331432/67a33dcd-447f-4c68-9c3c-ad954baddeb8 After PR:- https://github.com/facebook/react/assets/72331432/9f986ff2-785f-4cba-a504-44f82ea9fc5a --------- Co-authored-by: Biki das <bikidas@Bikis-MacBook-Pro.local>
Fixes #26200 ### PR explanation I tried to induce the change by the `event.composed` to check whether the event was created in a ShadowRoot, And replaced `pointerOver` with `pointerMove`, pointerOver event did not fired correctly Before PR:- https://github.com/facebook/react/assets/72331432/67a33dcd-447f-4c68-9c3c-ad954baddeb8 After PR:- https://github.com/facebook/react/assets/72331432/9f986ff2-785f-4cba-a504-44f82ea9fc5a --------- Co-authored-by: Biki das <bikidas@Bikis-MacBook-Pro.local> DiffTrain build for commit 9100456.
Using react while making a shadow DOM and then using react devtools inspect element feature does not work as expected video and codesandbox below
sandboxLink
https://stackblitz.com/edit/react-zqp67t?file=src/App.js
while attaching shadowroot
Mozilla.Firefox.2023-02-19.21-52-16.mp4
without attaching root
Mozilla.Firefox.2023-02-19.21-53-37.mp4
The text was updated successfully, but these errors were encountered: