-
Notifications
You must be signed in to change notification settings - Fork 47.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DevTools Bug]: React Profiler reports higher hook numbers than shown in Components #28584
Comments
Thank you for the detailed repro instructions. I can also reproduce this as instructed. I have a test reproducing the issue in #28587 that basically just inline all 3rd party dependencies. I haven't started further reducing the repro until it no longer reproduces but this should be a good starting point if somebody wants to dig into this. |
Same issue. Any thoughts on this? |
Any update on this? How is this not treated as a high priority bug anyway? |
It's really very annoying to debug component without correct profiler work. Is anybody alive here? Do you need reproduction? Or what? |
this is such an annoying bug, this has existed for nearly half a decade; but the people working on this are more obsessed with useless things like server components |
Issue is still present in 6.0.1 (10/15/2024) |
Website or app
https://github.com/3perf/react-workshop-fwdays-mar24
Repro steps
Clone the https://github.com/3perf/react-workshop-fwdays-mar24 repository
Switch to the branch called
day5
cd widgets-editor && yarn && yarn start
An app will open. Reproduce the following interaction & record a Profiler trace:
CleanShot.2024-03-19.at.01.33.16.mp4
Find the first render of the
ResizableComponent
component in the traceObserve React Profiler reporting “hook 32 changed” whereas the Components pane reporting only 30 hooks in the component (as in the video)
Sorry for not having a minimal repro! I was only able to reproduce this in big apps like the one attached. However, it reproduces reliably.
How often does this bug happen?
Every time
DevTools package (automated)
No response
DevTools version (automated)
No response
Error message (automated)
No response
Error call stack (automated)
No response
Error component stack (automated)
No response
GitHub query string (automated)
No response
The text was updated successfully, but these errors were encountered: