Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jquery-bootstrap example uses handleHidden which does not exist #5959

Closed
jimfb opened this issue Feb 1, 2016 · 2 comments · Fixed by #5961
Closed

jquery-bootstrap example uses handleHidden which does not exist #5959

jimfb opened this issue Feb 1, 2016 · 2 comments · Fixed by #5961
Labels
Difficulty: starter

Comments

@jimfb
Copy link
Contributor

jimfb commented Feb 1, 2016

Introduced in: 7f8b288
jimfb referenced this issue Feb 1, 2016
@zpao
[examples] Use refs instead of findDOMNode
3c0f46e
@piscolomo piscolomo mentioned this issue Feb 2, 2016
Closed
MarkMurphy added a commit to MarkMurphy/react that referenced this issue Feb 2, 2016
@MarkMurphy
Fixes facebook#5959 - jquery-bootstrap example uses which does not exist
3d1e79e
@MarkMurphy MarkMurphy mentioned this issue Feb 2, 2016
Merged
@MarkMurphy
Copy link
Contributor

@TheBlasfem you beat me to it haha! I noticed though that your fix doesn't address the fact that no event listener was added for the 'hidden' event to begin with. Also, the event name is actually hidden.bs.modal. I've made those changes in mine in addition to responding to the same onHidden prop you also implemented.

@piscolomo
Copy link
Contributor

nice catch @MarkMurphy, thanks for notice me, we can continue with your solution

MarkMurphy added a commit to MarkMurphy/react that referenced this issue Feb 2, 2016
@MarkMurphy
Fixes facebook#5959 - jquery-bootstrap example uses which does not exist
0bd65aa 
1. Add a handleHidden method to the BootstrapModal component.
2. Add an event listener for 'hidden.bs.modal' on the modal root
3. Add a new onHidden prop to the BootstrapModal component.
4. Add a new 'handleModalDidClose' method to the Example component to be used as the onHidden prop of it's modal component.
jimfb added a commit that referenced this issue Feb 2, 2016
@jimfb
Merge pull request #5961 from MarkMurphy/issue-5959
292f2b7 
Fixes #5959 - jquery-bootstrap example uses handleHidden which does not exist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Difficulty: starter
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #5959 - jquery-bootstrap example uses handleHidden which does not exist MarkMurphy/react
3 participants
@MarkMurphy @piscolomo @jimfb