IE 11 and Edge no longer prompt to remember password on controlled form #7328

lPadier · 2016-07-21T12:26:25Z

Do you want to request a feature or report a bug?
Bug (regression) IE/Edge

What is the current behavior?
On React > v15.2.0, Edge and IE11 do not prompt the user to save the password for the form

Steps to reproduce
With react 15.1.0:
https://jsfiddle.net/69z2wepo/49876/
With React 15.2.0:
https://jsfiddle.net/69z2wepo/49877/

What is the expected behavior?
The browser prompts the user to save their password for the form

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?
React > 15.2.0. It worked in React 15.2.0
IE 11, Edge

jdalton · 2016-11-10T00:55:16Z

This issue is caused by this commit 4338c8d#diff-5a2abece6f8c2495d8242daa40245434L156
which changed:

value: MUST_USE_PROPERTY | HAS_SIDE_EFFECTS,

to

value: 0,

It looks like the key is the HAS_SIDE_EFFECTS bit.
Changing the value, even if it's identical to the existing value, knocks off browser helpers in Edge.

I see that HAS_SIDE_EFFECTS was removed in a later version so that's something to account for.

Related to #6406 \cc @jimfb.

jdalton · 2016-11-18T00:00:29Z

@lPadier I've opened a PR at #8266.

florian-crewmeister · 2017-01-25T08:29:15Z

Any progress on this bug? The PR to fix it seems to be hanging around for a while and has not yet been merged.

nhunzaker · 2017-01-25T13:54:37Z

@aweary @jquense We should get test fixture coverage on this. It would be our first browser specific test case!

nippur72 · 2017-06-11T08:11:49Z

is there any workaround for this issue?

This commit replaces the method of synchronizing an input's value attribute from using setAttribute to assigning defaultValue. This has several benefits: - Fixes issue where IE10+ and Edge password icon disappears (#7328) - Fixes issue where toggling input types hides display value on dates in Safari (unreported) - Removes mutationMethod behaviors from DOMPropertyOperations

* Use defaultValue instead of setAttribute('value') This commit replaces the method of synchronizing an input's value attribute from using setAttribute to assigning defaultValue. This has several benefits: - Fixes issue where IE10+ and Edge password icon disappears (#7328) - Fixes issue where toggling input types hides display value on dates in Safari (unreported) - Removes mutationMethod behaviors from DOMPropertyOperations * initialValue in Input wrapperState is always a string * The value property is assigned before the value attribute. Fix related tests. * Remove initial value tests in ReactDOMInput I added these tests after removing the `value` mutation method. However they do not add any additional value over existing tests. * Improve clarity of value checks in ReactDOMInput.postMountWrapper * Remove value and defaultValue from InputWithWrapperState type They are already included in the type definition for HTMLInputElement * Inline stringification of value in ReactDOMInput Avoids eagier stringification and makes usage more consistent. * Use consistent value/defaultValue presence in postMountHook Other methods in ReactDOMInput check for null instead of hasOwnProperty. * Add missing semicolon * Remove unused value argument in ReactDOMInput test * Address cases where a value switches to undefined When a controlled input value switches to undefined, it reverts back to the initial state of the controlled input. We didn't have test coverage for this case, so I've added two describe blocks to cover both null and undefined.

PaloSP · 2018-03-27T11:22:10Z

For me this bug is still present in 16.2.0.
IE: 11.309.16299.0
EDGE : 41.16299.248.0

luisrudge · 2018-04-12T20:16:47Z

I'm still having this issue with both IE and Edge:

Works with 15.1.0: https://codesandbox.io/s/lpvz0zy9wq
Doesn't work with 15.2.0: https://codesandbox.io/s/o9kl2jzo1q
Doesn't work with 15.6.2: https://codesandbox.io/s/38kp95wl96
Doesn't work with 16.3.1: https://codesandbox.io/s/xjpk3wr55p

In order to test this effectively, you have to follow a few steps:

Using Edge, go to Settings >> View Advanced Settings, under Privacy and Services

make sure you have Offer to save passwords enabled:
make sure you don't have any passwords saved in the codesandbox.io domain:

Steps to reproduce when IT WORKS (15.1.0)

go to the 15.1.0 sandbox
type a username and a password and hit submit
you'll see a confirmation panel about saving passwords:
refresh the page
type another username and a password and hit submit
you'll see another confirmation panel about saving passwords:
refresh the page
click on the first input
you'll see a list of the previously used usernames:

Steps to reproduce when IT DOESN'T WORK (15.2.0, 15.6.2, 16.3.1)

remove previously saved passwords from the codesandbox.io domain:
go to any of the non-working sandboxes (15.2.0, 15.6.2, 16.3.1
type a username and a password and hit submit
there will be no password confirmation panel
refresh the page
click on the first input
there will be no list of previously used usernames

abbybhat · 2018-07-12T21:36:36Z

Is there a work around for this issue? I tried updating react to 16.4.1, didnt fix the issue for me

nhunzaker · 2018-07-13T14:10:26Z

@abbybhat Oh no! Can you send over a reproduction case?

danielpater · 2018-07-23T17:01:02Z

@nhunzaker The reproduction case was already provided by @luisrudge above. I updated it to 16.4.1:

Password prompt in IE 11 showing with 15.2.0:
https://lpvz0zy9wq.codesandbox.io/

Password prompt in IE 11 not showing with 16.4.1:
https://q7knzjrk8q.codesandbox.io/

gaearon · 2018-08-29T17:00:42Z

Seems like this wasn't fixed after all. We need to figure out why we thought this was fixed in #11534.

nhunzaker · 2018-08-29T17:11:52Z

There might have been a mismatch with the originally referenced issue in #8266, which was focused on the password reveal icon.

nhunzaker · 2018-08-29T23:44:00Z

I believe this works in Edge, but not IE11. I am still confirming IE11, but I need to step away for a bit. Here is what I found:

I setup a fixture for this, and I'm not having an issue getting the "remember password" flow". I have made a test fixture for this case here:

http://react-password-remember.surge.sh/password-inputs

And the associated diff:
https://github.com/facebook/react/compare/master...nhunzaker:password-remember-test-fixture?expand=1

This holds true for master, React 16.4, and React 16.3.

Additionally, I am not having an issue triggering the password flow in @luisrudge's example:

And I can also see the passwords saved in the manager:

nhunzaker · 2018-08-29T23:50:29Z

Looks like we already came to this conclusion in #12749. This does not work in IE11, and was being tracked to that issue.

zpao added the Component: DOM label Aug 3, 2016

jdalton mentioned this issue Nov 11, 2016

Preserve browser input behavior. #8266

Closed

nhunzaker mentioned this issue Jan 25, 2017

[RFC] Testing Browser Compatibility #8583

Closed

12 tasks

gaearon added the Type: Bug label Oct 4, 2017

gaearon changed the title ~~Regression React >=15.2.0: IE 11 and Edge no longer prompt to remember password on controlled form~~ IE 11 and Edge no longer prompt to remember password on controlled form Oct 4, 2017

nhunzaker mentioned this issue Oct 4, 2017

Add DOM fixture for unmasking passwords #9269

Merged

gaearon mentioned this issue Oct 4, 2017

Umbrella: React DOM Bugs #11097

Open

29 tasks

nhunzaker mentioned this issue Nov 12, 2017

Use defaultValue instead of setAttribute('value') #11534

Merged

17 tasks

gaearon closed this as completed in #11534 Nov 30, 2017

luisrudge mentioned this issue Apr 12, 2018

Auth0-lock does not integrate with password manager auth0/lock#857

Closed

luisrudge mentioned this issue May 5, 2018

IE 11 "prompt to remember password" regression bug since 15.2.0 #12749

Closed

gaearon reopened this Aug 29, 2018

gaearon mentioned this issue Aug 31, 2018

React Fire: Modernizing React DOM #13525

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

IE 11 and Edge no longer prompt to remember password on controlled form #7328

IE 11 and Edge no longer prompt to remember password on controlled form #7328

lPadier commented Jul 21, 2016 •

edited

Loading

jdalton commented Nov 10, 2016 •

edited

Loading

jdalton commented Nov 18, 2016

florian-crewmeister commented Jan 25, 2017

nhunzaker commented Jan 25, 2017

nippur72 commented Jun 11, 2017

PaloSP commented Mar 27, 2018

luisrudge commented Apr 12, 2018

abbybhat commented Jul 12, 2018

nhunzaker commented Jul 13, 2018

danielpater commented Jul 23, 2018

gaearon commented Aug 29, 2018

nhunzaker commented Aug 29, 2018

nhunzaker commented Aug 29, 2018

nhunzaker commented Aug 29, 2018

IE 11 and Edge no longer prompt to remember password on controlled form #7328

IE 11 and Edge no longer prompt to remember password on controlled form #7328

Comments

lPadier commented Jul 21, 2016 • edited Loading

jdalton commented Nov 10, 2016 • edited Loading

jdalton commented Nov 18, 2016

florian-crewmeister commented Jan 25, 2017

nhunzaker commented Jan 25, 2017

nippur72 commented Jun 11, 2017

PaloSP commented Mar 27, 2018

luisrudge commented Apr 12, 2018

Using Edge, go to Settings >> View Advanced Settings, under Privacy and Services

Steps to reproduce when IT WORKS (15.1.0)

Steps to reproduce when IT DOESN'T WORK (15.2.0, 15.6.2, 16.3.1)

abbybhat commented Jul 12, 2018

nhunzaker commented Jul 13, 2018

danielpater commented Jul 23, 2018

gaearon commented Aug 29, 2018

nhunzaker commented Aug 29, 2018

nhunzaker commented Aug 29, 2018

nhunzaker commented Aug 29, 2018

lPadier commented Jul 21, 2016 •

edited

Loading

jdalton commented Nov 10, 2016 •

edited

Loading