-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getRootIDs is not defined in ReactComponentTreeHook.js #8318
Comments
Can you reproduce this without Rollup? |
Not easily — I'm not sure I know of any code playgrounds that do ES6-style module imports… Any ideas? FWIW, this (obviously) works: https://jsfiddle.net/yvoy2g3x/ It's very possible that this is some side-effect of ES6-style module bundling. I tried replacing Buble with Babel, same problem. |
Might be a Rollup bug then? |
I'm seeing this too with rollup, I believe it's a rollup bug trimming too much code from the output - I opened rollup/rollup#1113 over there for the same issue |
Ah, sweet. Closing, then. |
Only declare the variable once in this scope, instead of declaring them multiple times in the same scope. This fixes facebook#8318, even though it might technically be a shortcoming in Rollup.
This could be fixed here as well though, declaring the same variable multiple times in the same scope doesn't seem that clean... Fix here: #8380 :) |
Only declare the variable once in this scope, instead of declaring them multiple times in the same scope. This fixes #8318, even though it might technically be a shortcoming in Rollup.
Only declare the variable once in this scope, instead of declaring them multiple times in the same scope. This fixes facebook#8318, even though it might technically be a shortcoming in Rollup.
Just started running into this bug today, everything was going smoothly before then. Only started happening after I updated to 15.4.0.
When I do
import React from 'react';
, this error gets thrown on the page when I try to use ReactDOM to render something to the DOM. Here's my code:I'm using React 15.4.0 and ReactDom 15.4.0, and bundling everything with Rollup and Buble.
Here's a screenshot of what Chrome tells me is happening:
The text was updated successfully, but these errors were encountered: