Cannot use addons.Perf or addons.ReactTransitionGroup in AMD environment with 15.4.1

[jochenberger]

I use react-with-addons in a RequireJS enviroment. If I try to use React.addons.Perf, I get a ReferenceError: ReactDOM is not defined from https://github.com/facebook/react/blob/15-dev/src/umd/shims/ReactAddonsDOMDependenciesUMDShim.js#L26.
This is a regression from 15.3.x.

[jochenberger]

See https://gist.github.com/jochenberger/9296b6edf23eada7a83ca22ca5685aa8

[gaearon]

This is a duplicate of #8301 and is being fixed in #8374. The fix will be out soon.

[gaearon]

I am leaving this open because need to confirm the fix actually fixes this issue as well.

[jochenberger]

No, this is about 15.4.1.

[gaearon]

Oh, I didn't realize 15.4.1 was already out, my bad.
Did this work with 15.4.0?

[jochenberger]

No, but it worked with 15.3.2, so it's also related to the change in packaging.

[gre]

Why is Perf depending on react-dom, it used to work in react-native context, is that no longer the case?

[gaearon]

@gre

The whole concept of "addons" that reach into internals is a mess IMO.

I think React Native has its own ReactPerf copy now but I'm not sure if it's exposed. You can probably get it with require('react-native/lib/ReactPerf'); or maybe just require('ReactPerf') (not sure how Haste works in RN projects).

We should probably expose it on renderers since it's copied now. Like ReactDOM.Perf and ReactNative.Perf or something.

[jochenberger]

ReactTransitionGroup is broken too, its cWRP calls ReactAddonsDOMDependencies.getReactInstanceMap() and that ends up in https://github.com/facebook/react/blob/15-dev/src/umd/shims/ReactAddonsDOMDependenciesUMDShim.js#L21 where ReactDOM is undefined.

[hsubox76]

I'm also using RequireJS and while 15.4.1 fixed the ability to use ReactDOM, I am unable to use React.addons.TestUtils.renderIntoDocument() for probably the same reasons as above.

renderIntoDocument makes use of ReactAddonsDOMDependencies.getReactTestUtils() which looks for the same undefined ReactDOM variable that ReactPerf and other addons are looking for I believe.

Thanks for getting the 15.4.1 fix out so quickly, by the way.

[gaearon]

It would really help if somebody could experiment with the bundle like in #8301 (comment) and try to figure out a fix before we get a chance to look into this.

[hsubox76]

Adding this require line in ReactAddonsDOMDependenciesUMDShim.js seems to fix it for me:
var ReactDOM = require('../../react-dom/lib/ReactDOMUMDEntry');

But I don't know if that's the correct way to do it. Gist here:

https://gist.github.com/hsubox76/6a81a00d2809c91c3b67d64ba7e1a518#file-reactaddonsdomdependenciesumdshim-js-L16

[gaearon]

This would break for single-file bundles as far as I can tell.

[jochenberger]

@hsubox76: what do you mean by "seems to fix it for me"? Have you tried to build the UMD distribution including this change?