WebComponents now requires class syntax #8656
Comments
This was referenced Dec 30, 2016
rektide
added a commit
to rektide/react
that referenced
this issue
Dec 30, 2016
This is a straightforward update of the WebComponent example to match the final 1.0 specification. To meet 1.0 spec, class syntax must be used. I'm unsure of any paths forward to maintaing support for old browsers while also supporting new ones, short of feature detection & having two codepaths.
|
Fixed in docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Do you want to request a feature or report a bug?
Bug
What is the current behavior?
Modern browsers no longer permit
Object.create(HTMLElement.prototype)as a means of creating Web Components. See:WebComponent demo uses this now-removed means of creating WebComponents.
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://jsfiddle.net or similar (template: https://jsfiddle.net/reactjs/69z2wepo/).
Running the linked webcomponent demo will throw an Uncaught TypeError.
What is the expected behavior?
The demo executes & renders.
Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?
I'm not sure when this change went into force in browsers. Chrome m55 that I'm on is broken. m54 was broken.
The text was updated successfully, but these errors were encountered: