Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix function arity issues #9817

Closed
1 of 2 tasks
bvaughn opened this issue May 30, 2017 · 4 comments
Closed
1 of 2 tasks

Fix function arity issues #9817

bvaughn opened this issue May 30, 2017 · 4 comments

Comments

@bvaughn
Copy link
Contributor

bvaughn commented May 30, 2017

Flow 0.46+ supports verifying the number of arguments passed to a function.

Enabling this feature (experimental.strict_call_arity=true) and updating to Flow ^0.46.0 in master results in 40 arity errors.
@iamdustan
Copy link
Contributor

Want me to rebase #9815 later?

@bvaughn
Copy link
Contributor Author

bvaughn commented May 30, 2017

Oh hey! Didn't see that PR yet.

PR #9816 resolves a few of the issues but not all of them. Happy to help track down the others.

@gaearon
Copy link
Collaborator

gaearon commented Jul 11, 2017

So did #9815 enable arity checks? Or do they need explicit opt in?

@bvaughn
Copy link
Contributor Author

bvaughn commented Jul 11, 2017 •
edited
Loading

Looks like #9815 turned them on, based on this which says:

Flow v0.47.0 will ship with strict function call arity turned on and the experimental.strict_call_arity flag will be removed.

I'm guessing that means we can close this now. I'm going to do that. If anyone knows of a reason to reopen it, let me know. 😄

@bvaughn bvaughn closed this as completed Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bvaughn @iamdustan @gaearon