-
Notifications
You must be signed in to change notification settings - Fork 47.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Flow 0.47 #9815
Update to Flow 0.47 #9815
Conversation
@@ -29,7 +29,7 @@ var validateCallback = require('validateCallback'); | |||
* @internal | |||
*/ | |||
class CallbackQueue<T> { | |||
_callbacks: ?Array<() => void>; | |||
_callbacks: ?Array<(...args: any) => void>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use mixed
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should I change all the any
s to mixed
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Donesies.
Also do you mind rebasing this on latest changes in master? |
Note that debugging why CI was failing I realized that one of the hydration context APIs did require an argument. It was typedef’d as |
Thank you! |
I was going to give rebasing #8545 a try and seeing what breaks, but first catching up to latest release of Flow. The big change here is that function call arity is now strictly enforces.
https://flow.org/blog/2017/05/07/Strict-Function-Call-Arity/
Specific call outs:
getPooled
andrelease
variadic arguments with...args: args
{is: is}
as the second arg tocreateElement
. ignored it with$FlowIssue
createElement
call was erroring because the entrystring
type was erroring when flowing into the more constrained types such as'span'
or'th'|'td'
. Got around it by changing thestring
type to the existential*
type.