Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use boolean assertion for documentMode check #10032

Merged
merged 1 commit into from
Aug 1, 2017

Conversation

aweary
Copy link
Contributor

@aweary aweary commented Jun 23, 2017

Resolves #10030

Reverts a small change made in #8575. This should be safe, as we still use this assertion for the change event bubbling check.

cc @flarnie @gaearon this will require another 15.6.x release (not sure if one was planned)

@aweary
Copy link
Contributor Author

aweary commented Jun 23, 2017

This change was already made in master as well: #7594 It just wasn't included in the backport.

@gaearon
Copy link
Collaborator

gaearon commented Jun 24, 2017

Why does #7594 change two lines but this PR changes one?

@aweary
Copy link
Contributor Author

aweary commented Jun 24, 2017

@gaearon
Copy link
Collaborator

gaearon commented Jun 25, 2017

Mind creating an issue linking to everything that's still necessary for 15.6.x? Another one I'm thinking about is CurrentOwner bugfix.

@gaearon
Copy link
Collaborator

gaearon commented Jun 26, 2017

Need to run prettier?

@aweary aweary mentioned this pull request Jun 26, 2017
12 tasks
@aweary
Copy link
Contributor Author

aweary commented Jun 26, 2017

@gaearon is the 15.6-dev branch meant to be working with prettier? I did run it locally but it was really out of sync, making the following changes:

	modified:   addons/create-react-class/test.js
	modified:   addons/react-addons-create-fragment/test.js
	modified:   addons/react-addons-linked-state-mixin/test.js
	modified:   addons/react-addons-pure-render-mixin/test.js
	modified:   addons/react-addons-shallow-compare/test.js
	modified:   addons/react-addons-update/test.js
	modified:   addons/react-linked-input/test.js
	modified:   src/renderers/dom/ReactDOM.js
	modified:   src/renderers/dom/client/ReactBrowserEventEmitter.js
	modified:   src/renderers/dom/client/ReactMount.js
	modified:   src/renderers/dom/client/syntheticEvents/SyntheticWheelEvent.js
	modified:   src/renderers/dom/shared/DOMProperty.js
	modified:   src/renderers/dom/shared/ReactComponentBrowserEnvironment.js
	modified:   src/renderers/dom/shared/hooks/ReactDOMUnknownPropertyHook.js
	modified:   src/renderers/native/ReactNative.js
	modified:   src/renderers/native/ReactNativeComponentEnvironment.js
	modified:   src/renderers/shared/ReactDebugTool.js
	modified:   src/renderers/shared/fiber/__tests__/ReactCoroutine-test.js
	modified:   src/renderers/shared/hooks/__tests__/ReactHostOperationHistoryHook-test.js
	modified:   src/renderers/shared/stack/event/eventPlugins/ResponderEventPlugin.js
	modified:   src/renderers/shared/stack/event/eventPlugins/TouchHistoryMath.js
	modified:   src/renderers/shared/stack/event/eventPlugins/__tests__/ResponderEventPlugin-test.js
	modified:   src/renderers/shared/stack/reconciler/ReactOwner.js
	modified:   src/renderers/shared/stack/reconciler/__tests__/ReactIdentity-test.js
	modified:   src/renderers/shared/utils/Transaction.js
	modified:   src/renderers/testing/ReactShallowRenderer.js
	modified:   src/test/ReactTestUtils.js

I can commit these changes (in a separate PR probably) if you'd like @gaearon

@gaearon
Copy link
Collaborator

gaearon commented Jun 26, 2017

Hmm. It used to work but maybe we're not yet using Yarn there so we need to cherry-pick #10038?

@aweary
Copy link
Contributor Author

aweary commented Jul 3, 2017

@gaearon cherry-picking #10038 doesn't seem to resolve it.

@nhunzaker
Copy link
Contributor

I think we might have gotten a false positive on the commit where we first ran prettier. I just re-ran the build without cache and it looks like the prettier step failed:

https://circleci.com/gh/facebook/react/4254

It's hard to tell what version of prettier ran - possibly 1.4 - but do you think we just need to run prettier 1.2.2.0 again on 15.6-dev as @aweary suggested?

@gaearon
Copy link
Collaborator

gaearon commented Jul 11, 2017

I'm cool either way, let's just get the branch to be green.

@aweary aweary force-pushed the fix-event-detection-ie-15.6 branch 2 times, most recently from 2e092ea to 2c70e8e Compare July 19, 2017 16:04
@aweary
Copy link
Contributor Author

aweary commented Jul 20, 2017

cc @gaearon @nhunzaker CI is now green 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants