Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node-stream.js to react-dom's package.json files entry #10044

Merged
merged 1 commit into from
Jun 26, 2017

Conversation

aickin
Copy link
Contributor

@aickin aickin commented Jun 26, 2017

In #10024, I added node-stream.js to react-dom's distribution, but I didn't realize that react-dom's package.json specifies which files are to be uploaded to the npm registry. As a result, if we tried to publish react-dom right now out of master, node-stream.js would not be a part of the package.

This PR fixes that. Sorry!

@gaearon gaearon merged commit 8e2b70c into facebook:master Jun 26, 2017
@magicmark
Copy link

@gaearon when/will this be available in a future release? It doesn't seem to be in 16.0.0-beta.5.

https://unpkg.com/react-dom@16.0.0-beta.5/package.json

(It was in 16.0.0-beta.2 - https://unpkg.com/react-dom@16.0.0-beta.2/package.json)

(The docs reference this API, which appears to have been recently updated)

Thanks so much!

@gaearon
Copy link
Collaborator

gaearon commented Aug 28, 2017

@magicmark In the latest release, they're just available directly on react-dom/server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants