Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types Fiber as an exact object type #10063

Merged
merged 1 commit into from
Jun 28, 2017
Merged

Conversation

koba04
Copy link
Contributor

@koba04 koba04 commented Jun 28, 2017

Fiber is a fixed data structure. It shares the same hidden class. Never add fields outside of construction in ReactFiber.

#7942

I think Flowtype's exact object type makes sense to guarantee this.

@acdlite acdlite merged commit 85f3498 into facebook:master Jun 28, 2017
@koba04 koba04 deleted the fiber-exact-type branch June 29, 2017 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants