Simplify environment injections #10175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was necessary when they shared global state. But now these are flat bundles so we can inject as side effect. This feels a bit less convoluted to me. Ideally we can get rid of this somehow soon.
gaearon
commented
Jul 13, 2017
| @@ -23,40 +23,24 @@ var ReactDOMEventListener = require('ReactDOMEventListener'); | |||
| var SelectEventPlugin = require('SelectEventPlugin'); | |||
| var SimpleEventPlugin = require('SimpleEventPlugin'); | |||
|
|
|||
| var alreadyInjected = false; | |||
| ReactDOMEventListener.setHandleTopLevel( | |||
There was a problem hiding this comment.
This is just putting method content outside. Variable is no longer needed.
sophiebits
approved these changes
Jul 13, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not that it simplifies much.. But I just removed the function wrappers because they are no longer necessary. With flat bundles there’s no shared state so this is safe.