Skip to content

Remove Error event listener eagerly instead of using depth count #10296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2017
Merged

Remove Error event listener eagerly instead of using depth count #10296

merged 1 commit into from
Jul 27, 2017
+8 −15

Conversation

sebmarkbage
Copy link
Collaborator

@sebmarkbage sebmarkbage commented Jul 26, 2017 •
edited
Loading

A little simpler.

Test Plan: dom fixture /error-handling. Passes instructions.

@sebmarkbage
Remove Error event listener eagerly instead of using depth count

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
f67b887 
A little simpler.
@sebmarkbage sebmarkbage requested review from gaearon and acdlite July 26, 2017 23:43
sophiebits
sophiebits reviewed Jul 27, 2017
View reviewed changes
Copy link
Collaborator

@sophiebits sophiebits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

acdlite
acdlite approved these changes Jul 27, 2017
View reviewed changes
Copy link
Collaborator

@acdlite acdlite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

piotrek1543
piotrek1543 reviewed Jul 27, 2017
View reviewed changes
Copy link

@piotrek1543 piotrek1543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and effective. Congrats!

@sebmarkbage sebmarkbage merged commit e1cfd6c into facebook:master Jul 27, 2017
@Andarist Andarist mentioned this pull request Aug 9, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophiebits sophiebits

@piotrek1543 piotrek1543

@acdlite acdlite

@gaearon gaearon

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sebmarkbage @sophiebits @acdlite @piotrek1543 @facebook-github-bot