Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log captured errors sooner #10373

Merged
merged 1 commit into from
Aug 3, 2017

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Aug 3, 2017

This prevents the captured error from becoming separated from the component stack if other errors (or console.error calls) are made between them, eg a component errors during unmount.

Relates to discussion on #10353 as well as out-of-band (not on GitHub) discussion.

Before

screen shot 2017-08-03 at 11 39 29 am

After

screen shot 2017-08-03 at 2 48 53 pm

This prevents the captured error from becoming separated from the component stack if other errors (or console.error calls) are made between them, eg a component errors during unmount.
Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lg

@bvaughn bvaughn merged commit 6188832 into facebook:master Aug 3, 2017
@bvaughn bvaughn deleted the log-captured-errors-sooner branch August 3, 2017 22:51
@bvaughn bvaughn mentioned this pull request Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants