Warn about unresolved function as a child #10376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebmarkbage
reviewed
Aug 4, 2017
| @@ -493,4 +493,78 @@ describe('ReactComponent', () => { | |||
| ' in Foo (at **)', | |||
| ); | |||
| }); | |||
|
|
|||
| if (ReactDOMFeatureFlags.useFiber) { | |||
| fdescribe('with new features', () => { | |||
|
Ran Jest internally with a |
flarnie
reviewed
Aug 4, 2017
| @@ -200,6 +200,16 @@ function throwOnInvalidObjectType(returnFiber: Fiber, newChild: Object) { | |||
| } | |||
| } | |||
|
|
|||
| function warnOnFunctionType() { | |||
| warning( | |||
| false, | |||
There was a problem hiding this comment.
Why not pass in newChild and put typeof newChild !== 'function' instead of false?
There was a problem hiding this comment.
To avoid two extra functions calls in DEV. (It's small but can add up.)
Also I find our warning notation with falsy condition meaning a failure very confusing. I try to avoid it whenever I write warnings, and always use warning(false so it’s clear from outer condition in which case it executes.
flarnie
approved these changes
Aug 4, 2017
Closed
|
@gaearon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9577.